Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Docs: addmultisigaddress is intended for non-watchonly addresses #10677

Merged
merged 1 commit into from
Jan 6, 2018

Conversation

instagibbs
Copy link
Member

Spent a couple hours debugging why my p2sh watchonly funds were not appearing in various accounting calls when address was imported via addmultisigaddress.

@instagibbs
Copy link
Member Author

segwit.py randomly failing:

AssertionError: not(b'bad-txns-vout-negative' == b'bad-witness-nonstandard')

I'm assuming this is unrelated

@jonasschnelli
Copy link
Contributor

ACK 73041c3
Kicked travis.

@fanquake
Copy link
Member

fanquake commented Jul 6, 2017

utACK 73041c3

@instagibbs
Copy link
Member Author

this is a straight forward help text PR, would be nice for 0.15

@maflcko maflcko added this to the 0.16.0 milestone Nov 18, 2017
@instagibbs
Copy link
Member Author

any objection to merge?

@promag
Copy link
Contributor

promag commented Dec 12, 2017

ACK 73041c3.

@sipa
Copy link
Member

sipa commented Jan 6, 2018

ACK 73041c3

@sipa sipa merged commit 73041c3 into bitcoin:master Jan 6, 2018
sipa added a commit that referenced this pull request Jan 6, 2018
…nly addresses

73041c3 RPC Docs: addmultisigaddress is intended for non-watchonly addresses (Gregory Sanders)

Pull request description:

  Spent a couple hours debugging why my p2sh watchonly funds were not appearing in various accounting calls when address was imported via `addmultisigaddress`.

Tree-SHA512: 0673e276e5ca8cdc4c9357bd835a29bd5a994520a78179600944932c700917142930288bf179f5e89b0874beaf1a88bd70129f3a297a46df42a10bab847017bb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 13, 2020
…-watchonly addresses

73041c3 RPC Docs: addmultisigaddress is intended for non-watchonly addresses (Gregory Sanders)

Pull request description:

  Spent a couple hours debugging why my p2sh watchonly funds were not appearing in various accounting calls when address was imported via `addmultisigaddress`.

Tree-SHA512: 0673e276e5ca8cdc4c9357bd835a29bd5a994520a78179600944932c700917142930288bf179f5e89b0874beaf1a88bd70129f3a297a46df42a10bab847017bb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 13, 2020
…-watchonly addresses

73041c3 RPC Docs: addmultisigaddress is intended for non-watchonly addresses (Gregory Sanders)

Pull request description:

  Spent a couple hours debugging why my p2sh watchonly funds were not appearing in various accounting calls when address was imported via `addmultisigaddress`.

Tree-SHA512: 0673e276e5ca8cdc4c9357bd835a29bd5a994520a78179600944932c700917142930288bf179f5e89b0874beaf1a88bd70129f3a297a46df42a10bab847017bb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 16, 2020
…-watchonly addresses

73041c3 RPC Docs: addmultisigaddress is intended for non-watchonly addresses (Gregory Sanders)

Pull request description:

  Spent a couple hours debugging why my p2sh watchonly funds were not appearing in various accounting calls when address was imported via `addmultisigaddress`.

Tree-SHA512: 0673e276e5ca8cdc4c9357bd835a29bd5a994520a78179600944932c700917142930288bf179f5e89b0874beaf1a88bd70129f3a297a46df42a10bab847017bb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 16, 2020
…-watchonly addresses

73041c3 RPC Docs: addmultisigaddress is intended for non-watchonly addresses (Gregory Sanders)

Pull request description:

  Spent a couple hours debugging why my p2sh watchonly funds were not appearing in various accounting calls when address was imported via `addmultisigaddress`.

Tree-SHA512: 0673e276e5ca8cdc4c9357bd835a29bd5a994520a78179600944932c700917142930288bf179f5e89b0874beaf1a88bd70129f3a297a46df42a10bab847017bb
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 29, 2020
…chonly addresses

Summary:
73041c3 RPC Docs: addmultisigaddress is intended for non-watchonly addresses (Gregory Sanders)

Pull request description:

  Spent a couple hours debugging why my p2sh watchonly funds were not appearing in various accounting calls when address was imported via `addmultisigaddress`.

---

Backport of Core [[bitcoin/bitcoin#10677 | PR10677]]

Test Plan:
  ninja

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8180
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants