Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: add 2nd arg to signrawtransactionwithkey examples #16210

Merged
merged 1 commit into from
Jun 17, 2019
Merged

rpc: add 2nd arg to signrawtransactionwithkey examples #16210

merged 1 commit into from
Jun 17, 2019

Conversation

dooglus
Copy link
Contributor

@dooglus dooglus commented Jun 14, 2019 •
edited by maflcko
Loading

The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

Before this change the help text showed:

Examples:
> bitcoin-cli signrawtransactionwithkey "myhex"
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

With the change, it shows:

Examples:
> bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]"
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

@dooglus
Add example 2nd arg to signrawtransactionwithkey
71fd628 
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.
@promag
Copy link
Contributor

promag commented Jun 14, 2019

ACK, should be backport I guess.

@fanquake fanquake changed the title Add 2nd arg to signrawtransactionwithkey examples rpc: add 2nd arg to signrawtransactionwithkey examples Jun 14, 2019
@dooglus
Copy link
Contributor Author

dooglus commented Jun 14, 2019

Do I need to do anything more or can I leave this with you guys? I don't know the correct dance steps to get things merged.

@promag
Copy link
Contributor

promag commented Jun 14, 2019

You are good.

@Empact
Copy link
Contributor

Empact commented Jun 17, 2019

Concept ACK

Maybe call example keys: "myprivkeyX" to be slightly more explicit?

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jun 17, 2019
@dooglus
Add example 2nd arg to signrawtransactionwithkey
d24d0ec 
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

Github-Pull: bitcoin#16210
Rebased-From: 71fd628
@maflcko maflcko merged commit 71fd628 into bitcoin:master Jun 17, 2019
maflcko pushed a commit that referenced this pull request Jun 17, 2019
Merge #16210: rpc: add 2nd arg to signrawtransactionwithkey examples
91958d6 
71fd628 Add example 2nd arg to signrawtransactionwithkey (Chris Moore)

Pull request description:

  The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

  Before this change the help text showed:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

  With the change, it shows:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

ACKs for commit 71fd62:

Tree-SHA512: dadf6bf0ba64ac356b7b8f9ed4d483384b70080ac4b1664b27a2e72b97f25d7266f3dae89fbeade73c1bae802b5bae7b84d596c93a9ae9c748851ae35758d9a6
@dooglus dooglus deleted the patch-7 branch June 18, 2019 01:28
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Aug 23, 2019
@dooglus
Add example 2nd arg to signrawtransactionwithkey
782129c 
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

Github-Pull: bitcoin#16210
Rebased-From: 71fd628
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Aug 24, 2019
@dooglus @Bushstar
Add example 2nd arg to signrawtransactionwithkey
79dffb1 
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

Github-Pull: bitcoin#16210
Rebased-From: 71fd628
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Dec 7, 2021
@vijaydasmp
Merge bitcoin#16210: rpc: add 2nd arg to signrawtransactionwithkey ex…
6e2ba65 
…amples

71fd628 Add example 2nd arg to signrawtransactionwithkey (Chris Moore)

Pull request description:

  The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

  Before this change the help text showed:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

  With the change, it shows:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

ACKs for commit 71fd62:

Tree-SHA512: dadf6bf0ba64ac356b7b8f9ed4d483384b70080ac4b1664b27a2e72b97f25d7266f3dae89fbeade73c1bae802b5bae7b84d596c93a9ae9c748851ae35758d9a6
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Dec 11, 2021
@vijaydasmp
Merge bitcoin#16210: rpc: add 2nd arg to signrawtransactionwithkey ex…
ff81ab1 
…amples

71fd628 Add example 2nd arg to signrawtransactionwithkey (Chris Moore)

Pull request description:

  The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

  Before this change the help text showed:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

  With the change, it shows:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

ACKs for commit 71fd62:

Tree-SHA512: dadf6bf0ba64ac356b7b8f9ed4d483384b70080ac4b1664b27a2e72b97f25d7266f3dae89fbeade73c1bae802b5bae7b84d596c93a9ae9c748851ae35758d9a6
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Dec 13, 2021
@vijaydasmp
Merge bitcoin#16210: rpc: add 2nd arg to signrawtransactionwithkey ex…
d561cbc 
…amples

71fd628 Add example 2nd arg to signrawtransactionwithkey (Chris Moore)

Pull request description:

  The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

  Before this change the help text showed:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

  With the change, it shows:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

ACKs for commit 71fd62:

Tree-SHA512: dadf6bf0ba64ac356b7b8f9ed4d483384b70080ac4b1664b27a2e72b97f25d7266f3dae89fbeade73c1bae802b5bae7b84d596c93a9ae9c748851ae35758d9a6
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Dec 14, 2021
@vijaydasmp
Merge bitcoin#16210: rpc: add 2nd arg to signrawtransactionwithkey ex…
af1d45e 
…amples

71fd628 Add example 2nd arg to signrawtransactionwithkey (Chris Moore)

Pull request description:

  The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

  Before this change the help text showed:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

  With the change, it shows:

      Examples:
      > bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]"
      > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/

ACKs for commit 71fd62:

Tree-SHA512: dadf6bf0ba64ac356b7b8f9ed4d483384b70080ac4b1664b27a2e72b97f25d7266f3dae89fbeade73c1bae802b5bae7b84d596c93a9ae9c748851ae35758d9a6
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dooglus @promag @Empact @fanquake @maflcko