test: make the node param explicit in init_wallet() #23316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsilva01
changed the title
|
Concept ACK |
stratospher
reviewed
Oct 20, 2021
There was a problem hiding this comment.
tested ACK 7b3c9e4.
This is a nice change! The function call self.init_wallet(node=0) is more understandable compared to self.init_wallet(0). This call format is also consistent with other functions from the codebase like test_cltv_info and test_dersig_info which are defined in a similar manner. Verified that there aren’t other instances making the init_wallet() call.
jonatack
reviewed
Oct 20, 2021
| self.init_wallet(2) | ||
| self.init_wallet(node=0) | ||
| self.init_wallet(node=1) | ||
| self.init_wallet(node=2) |
There was a problem hiding this comment.
def init_three(self):
- self.init_wallet(node=0)
- self.init_wallet(node=1)
- self.init_wallet(node=2)
+ for n in range(3):
+ self.init_wallet(node=n)There was a problem hiding this comment.
Made the change in #23327.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 20, 2021
7b3c9e4 Make explicit the node param in init_wallet() (lsilva01) Pull request description: This PR changes the definition of `def init_wallet(self, i)` to `def init_wallet(self, *, node)` to make the node parameter explicit, as suggested in bitcoin#22794 (comment) . ACKs for top commit: stratospher: tested ACK 7b3c9e4. Tree-SHA512: 2ef036f4c2110b2f7dc893dc6eea8faa0a18edd7f8f59b25460a6c544df7238175ddd6a0d766e2bb206326b1c9afc84238c75613a0f01eeda89a8ccb7d86a4f1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the definition of
def init_wallet(self, i)todef init_wallet(self, *, node)to make the node parameter explicit, as suggested in #22794 (comment) .