Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: convert shell locale linter test to Python #24929

Merged
merged 1 commit into from
Apr 25, 2022
Merged

lint: convert shell locale linter test to Python #24929

merged 1 commit into from
Apr 25, 2022

Conversation

Eunoia1729
Copy link
Contributor

Refs #24783

@DrahtBot DrahtBot added the Tests label Apr 20, 2022
@Eunoia1729 Eunoia1729 force-pushed the lint-shell-locale-py branch from b1230cc to caacd73 Compare April 20, 2022 07:45
@Kvaciral
Copy link
Contributor

The utf8-encoding-linter fails because of the whitespaces around the = in with open(file_path, 'r', encoding = 'utf-8') as file_obj: on line 47

@Eunoia1729 Eunoia1729 force-pushed the lint-shell-locale-py branch from caacd73 to 2c838cc Compare April 20, 2022 14:38
@Eunoia1729
Copy link
Contributor Author

Eunoia1729 commented Apr 20, 2022 •
edited
Loading

The utf8-encoding-linter fails because of the whitespaces around the = in with open(file_path, 'r', encoding = 'utf-8') as file_obj: on line 47

Ahh. Thanks for pointing it out ! Today I learnt that it's a convention to not use spaces around = for keyword arguments. 😅

@Eunoia1729
Copy link
Contributor Author

Before change:
Screenshot from 2022-04-16 13-01-54

After change:
Screenshot from 2022-04-16 13-01-32

@laanwj laanwj mentioned this pull request Apr 21, 2022
Closed
25 tasks
@laanwj
Copy link
Member

laanwj commented Apr 25, 2022

Code review ACK 2c838cc

@laanwj laanwj merged commit 777b89b into bitcoin:master Apr 25, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 26, 2022
@laanwj
Merge bitcoin#24929: lint: convert shell locale linter test to Python
48bf757
@bitcoin bitcoin locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Eunoia1729 @Kvaciral @laanwj @DrahtBot