Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Naming discussion welcome. Previous naming thread at #24697 (comment) |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
ajtowns
reviewed
May 11, 2022
ajtowns
reviewed
May 11, 2022
ajtowns
reviewed
May 11, 2022
|
Rebased for changes in |
jonatack
reviewed
May 16, 2022
This was referenced May 17, 2022
|
Rebased. Should be trivial to re-review |
|
ACK fa305fd per |
|
ACK fa305fd |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 28, 2022
fa305fd Add mockable clock type and TicksSinceEpoch helper (MarcoFalke) Pull request description: This will be used primarily by the addr time refactor (bitcoin#24697) to make addr relay time type safe. However, it can also be used in other places, and can be reviewed independently, so I split it up. ACKs for top commit: jonatack: ACK fa305fd per `git range-diff 7b3343f fa20781 fa305fd` ajtowns: ACK fa305fd Tree-SHA512: da00200126833c1f55b1b1e68f596eab5c9254e82b188ad17779c08ffd685e198a7c5270791b4b69a858dc6ba4e051fe0c8b445d203d356d0c884f6365ee1cfe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used primarily by the addr time refactor (#24697) to make addr relay time type safe. However, it can also be used in other places, and can be reviewed independently, so I split it up.