Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destroy to BlockTemplate schema #31288

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add destroy to BlockTemplate schema #31288

merged 1 commit into from
Nov 20, 2024

Conversation

Sjors
Copy link
Member

@Sjors Sjors commented Nov 14, 2024 •
edited
Loading

This ensures that if a client no longer needs a block template, the node can clear its memory as soon as possible.

A block template may hold on to transactions that are no longer in the mempool, so this can be significant.

This has a trivial silent merge conflict with #31283 because it also used the number @9 (gaps are not allowed). I'll rebase whichever is merged last.

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 14, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31288.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan, ryanofsky

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #31283 (Add waitNext() to BlockTemplate interface by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@Sjors
Copy link
Member Author

Sjors commented Nov 14, 2024

@ryanofsky can you further clarify what the difference in behavior is with an without a destroy method?

This was referenced Nov 14, 2024
Open
Open
ryanofsky
ryanofsky approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 5f7dc0d

@ryanofsky can you further clarify what the difference in behavior is with an without a destroy method?

I think it probably doesn't matter too much in this case, since the only thing the destroy method will currently do is free memory. But this does help future proof the interface, in case we want the destructor to do more things in the future, or if we add memory limits and want to give clients a way to ensure that previous block templates were completely freed before they create new ones.

The difference technically between having a destroy method and not having one is that when a libmultiprocess c++ IPC client destroys an object, it will automatically call the destroy method and wait for the server object to be destroyed before returning to client code. Without a destroy method, the C++ client object will be destroyed immediately without waiting for the server object to be destroyed. There's some documentation about this in https://github.com/chaincodelabs/libmultiprocess/blob/abe254b9734f2e2b220d1456de195532d6e6ac1e/include/mp/proxy.h#L80-L91

src/ipc/capnp/mining.capnp Outdated
@@ -33,6 +33,7 @@ interface BlockTemplate $Proxy.wrap("interfaces::BlockTemplate") {
getWitnessCommitmentIndex @6 (context: Proxy.Context) -> (result: Int32);
getCoinbaseMerklePath @7 (context: Proxy.Context) -> (result: List(Data));
submitSolution@8 (context: Proxy.Context, version: UInt32, timestamp: UInt32, nonce: UInt32, coinbase :Data) -> (result: Bool);
destroy @9 (context :Proxy.Context) -> ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit "Add destroy to BlockTemplate schema" (5f7dc0d)

Would suggest making destroy the first method because it affect semantics of the object as a whole, and thats where I placed destroy in all the other interfaces. It is fine to keep the number @9 for it, or renumber if you prefer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved destroy to the top and renumbered.

TheCharlatan
TheCharlatan approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b28972c

@DrahtBot DrahtBot requested a review from ryanofsky November 15, 2024 09:46
@DrahtBot DrahtBot mentioned this pull request Nov 15, 2024
Open
ryanofsky
ryanofsky approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK b28972c

src/ipc/capnp/mining.capnp Outdated
getCoinbaseCommitment @6 (context: Proxy.Context) -> (result: Data);
getWitnessCommitmentIndex @7 (context: Proxy.Context) -> (result: Int32);
getCoinbaseMerklePath @8 (context: Proxy.Context) -> (result: List(Data));
submitSolution@9 (context: Proxy.Context, version: UInt32, timestamp: UInt32, nonce: UInt32, coinbase :Data) -> (result: Bool);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit "Add destroy to BlockTemplate schema" (b28972c)

note: Missing a space before the number this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the space.

@Sjors
Add destroy to BlockTemplate schema
9aa5015 
This ensures that if a client no longer needs a block template,
the node can clear its memory as soon as possible.

A block template may hold on to transactions that are no longer
in the mempool, so this can be significant.
TheCharlatan
TheCharlatan approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@TheCharlatan TheCharlatan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ACK 9aa5015

@DrahtBot DrahtBot requested a review from ryanofsky November 15, 2024 19:44
ryanofsky
ryanofsky approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 9aa5015

@ryanofsky
Copy link
Contributor

Will go ahead and merge even though it only has 2 acks, since it's basically just adding a line to a schema file. Having this merged should make the related PR easier to maintain and review.

@ryanofsky ryanofsky self-assigned this Nov 20, 2024
@ryanofsky ryanofsky merged commit 22ef95d into bitcoin:master Nov 20, 2024
16 checks passed
@Sjors Sjors deleted the 2024/11/destroy branch November 21, 2024 08:42
TheCharlatan added a commit to TheCharlatan/rust-bitcoinkernel that referenced this pull request Dec 3, 2024
@TheCharlatan
Squashed 'libbitcoinkernel-sys/bitcoin/' changes from 403c20980ec..99…
bd64a55 
…7c2ccc920

997c2ccc920 Add hooks for script debug callbacks
8598bc9e5d3 kernel: Add pure kernel bitcoin-chainstate
07530efd10c kernel: Add functions to get the block hash from a block
1a871d96afd kernel: Add block index utility functions to C header
a50a97dec8e kernel: Add function to read block undo data from disk to C header
093489acee8 kernel: Add functions to read block from disk to C header
8a4b4fdefab kernel: Add function for copying  block data to C header
b09983496ae kernel: Add functions for the block validation state to C header
c445389d749 kernel: Add validation interface to C header
94f65e6fc8c kernel: Add interrupt function to C header
a7eac722561 kernel: Add import blocks function to C header
c6a7574247f kernel: Add chainstate load options for in-memory dbs in C header
6f7bb78869c kernel: Add options for reindexing in C header
46f5909e6d8 kernel: Add block validation to C header
1680886ba03 Kernel: Add chainstate loading to kernel C header
4aad77d2665 kernel: Add chainstate manager option for setting worker threads
c92849c7b51 kernel: Add chainstate manager object to C header
e420bbddf36 kernel: Add notifications context option to C header
d3c6127e0d3 kerenl: Add chain params context option to C header
4bc8c494693 kernel: Add kernel library context object
df66c7b0ff2 kernel: Add logging to kernel library C header
a78aeb9ff0e kernel: Introduce initial kernel C header API
6cd95de2e02 Merge bitcoin/bitcoin#31395: build: Set shared linker flags in toolchain file
abeebccc480 Merge bitcoin/bitcoin#31357: cmake: Improve build script correctness
4c9b13841c4 Merge bitcoin/bitcoin#31402: doc: correct libfuzzer-nosan preset flag
da4f4fac8df Merge bitcoin/bitcoin#31361: cmake, qt: Use absolute paths for includes in MOC-generated files
16b140f225a doc: correct libfuzzer-nosan preset flag
097c66f6148 Merge bitcoin/bitcoin#30039: dbwrapper: Bump LevelDB max file size to 32 MiB to avoid system slowdown from high disk cache flush rate
68daaea0e48 Merge bitcoin/bitcoin#31390: Remove `src/config` directory
14f162dc5c8 Merge bitcoin/bitcoin#31399: ci, macos: Install `pkgconf` Homebrew's package
e2f2698395c ci, macos: Install `pkgconf` Homebrew's package
b73d3319377 dbwrapper: Bump max file size to 32 MiB
a8e04704f93 build: Set shared linker flags in toolchain file
dbc8ba12f3b Merge bitcoin/bitcoin#31371: doc, test: more ephemeral dust follow-ups
935973b315f Remove `src/config` directory
7590e93bc73 Merge bitcoin/bitcoin#30986: contrib: skip missing binaries in gen-manpages
b2af068825c Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity
144f98db85e Merge bitcoin/bitcoin#31337: build: Fix coverage builds
efdb49afb9e Merge bitcoin/bitcoin#31323: guix: swap `moreutils` for just `sponge`
37a5c5d8366 doc: update descriptors.md for getdescriptoractivity
ee3ce6a4f4d test: rpc: add no address case for getdescriptoractivity
811f76f3a51 rpc: add getdescriptoractivity
ee6185372fc gen-manpages: Prompt error if no binaries are found
70e20ea024c Merge bitcoin/bitcoin#31172: build: increase minimum supported Windows to 10.0
733317ba943 Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
5a4bc5c0366 Merge bitcoin/bitcoin#31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors
28fd0bc7316 Merge bitcoin/bitcoin#31365: interpreter: Use the same type for SignatureHash in the definition
72ab35a6d09 Merge bitcoin/bitcoin#31221: ci: Split out native fuzz jobs for macOS and windows (take 2)
160799d9135 test: refactor: introduce `create_ephemeral_dust_package` helper
61e18dec306 doc: ephemeral policy: add missing closing double quote
3305972f7bf refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
11f3bc229cc refactor: Reserve vectors in fuzz tests
152fefe7a22 refactor: Preallocate PrevectorFillVector(In)Direct without vector resize
a774c7a339c refactor: Fix remaining clang-tidy performance-inefficient-vector errors
f7144b24be0 Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups
c288c790cd9 interpreter: Use the same type for SignatureHash in the definition
b031b7910d6 [ci] Split out native fuzz jobs for macOS and windows
6f4128e3a83 cmake, qt: Use absolute paths for includes in MOC-generated files
ab5c63edcce cmake: Build `secp256k1` only when required
76a3a540a4c cmake: Ensure script correctness when no targets are specified
e8f50c5debe guix: swap moreutils for just sponge
01a7298818d build: Avoid using the `-ffile-prefix-map` compiler option
2638fdb4f93 Merge bitcoin/bitcoin#31338: test: Deduplicate assert_mempool_contents()
17834bd1976 Merge bitcoin/bitcoin#31333: fuzz: Implement G_TEST_GET_FULL_NAME
cf577227888 Merge bitcoin/bitcoin#31335: macOS: swap docs & CI from pkg-config to pkgconf
fe3457ccfff ci: note that we should install pkgconf in future
a0eafc10f94 functional test: Deduplicate assert_mempool_contents()
8d203480b33 doc: migrate from pkg-config to pkgconf in macOS build docs
466e4df3fb8 assert_mempool_contents: assert not duplicates expected
ea5db2f2692 functional: only generate required blocks for test
d033acb6083 fuzz: package_eval: let fuzzer run out input in main tx creation loop
ba35a570c5d CheckEphemeralSpends: return boolean, and set child state and txid outparams
cf0cee1617c func: add note about lack of 1P1C propagation in tree submitpackage
84242903043 unit test: ephemeral_tests is using a dust relay rate, not minrelay
d9cfa5fc4eb CheckEphemeralSpends: no need to iterate inputs if no parent dust
87b26e3dc07 func: rename test_free_relay to test_no_minrelay_fee
e5709a4a41e func: slight elaboration on submitpackage restriction
08e969bd107 RPC: only enforce dust rules on priority when standardness active
ca050d12e76 unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX
7c3490169c9 fuzz: package_eval: move last_tx inside txn ctor
445eaed182a fuzz: use optional status instead of should_rbf_eph_spend
4dfdf615b9d fuzz: remove unused TransactionsDelta validation interface
09ce926e4a1 func: cleanup reorg test comment
768a0c1889e func: cleanup test_dustrelay comments
bedca1cb663 fuzz: Directly place transactions in vector
c041ad6eccb fuzz: explain package eval coin tracking better
bc0d98ea612 fuzz: remove dangling reference to GetEntry
15b6cbf07f5 unit test: make dust index less magical
5fbcfd12b8f unit test: assert txid returned on CheckEphemeralSpends failures
ef94d84b4e4 bench: remove unnecessary CMTxn constructors
c5c10fd317c ephemeral policy doxygen cleanup
dd9044b8d46 ephemeral policy: IWYU
c6859ce2de7 Move+rename GetDustIndexes -> GetDust
22ef95dbe3e Merge bitcoin/bitcoin#31288: Add destroy to BlockTemplate schema
92d3d691f09 fuzz: Implement G_TEST_GET_FULL_NAME
f34fe0806a0 Merge bitcoin/bitcoin#31122: cluster mempool: Implement changeset interface for mempool
b2d952c0f5b Merge bitcoin/bitcoin#31331: doc: add copyright header to p2p_headers_presync
7d3703dec3d doc: add copyright header to p2p_headers_presync
116b8c55736 Merge bitcoin/bitcoin#31213: fuzz: Fix difficulty target generation in `p2p_headers_presync`
15c1f47a005 Merge bitcoin/bitcoin#31327: doc: Correct PR Review Club frequency from weekly to monthly
1209a1082c8 Merge bitcoin/bitcoin#31315: build: Enable -Wbidi-chars=any
ab22726def9 Merge bitcoin/bitcoin#31276: guix: scope pkg-config to Linux only
637f437a164 doc: remove PR Review Club frequency
e1223099584 Merge bitcoin/bitcoin#31317: test: Revert to random path element
2666d83da59 Merge bitcoin/bitcoin#30893: test: Introduce ensure_for helper
faaaf59f71e test: Make g_rng_temp_path rand, not dependent on SeedRandomForTest
746f93b4f0f Merge bitcoin/bitcoin#31307: build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
25fe087de59 rpc: move-only: move ScriptPubKeyDoc to utils
fa80b08fef0 test: Revert to random path element
fa7857ccda5 build: Enable -Wbidi-chars=any
b2d53610028 build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
9aa50152c1c Add destroy to BlockTemplate schema
ccc2d3abcd3 Merge bitcoin/bitcoin#31287: refactor: Avoid std::string format strings
62016b32300 Use std::ranges for ephemeral policy checks
3ed930a1f41 Have HasDust and PreCheckValidEphemeralTx take CTransaction
04a614bf9a7 Rename CheckValidEphemeralTx to PreCheckEphemeralTx
85bcfeea235 Merge bitcoin/bitcoin#30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment
2257c6d68fa Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks
380e1f44e8e Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues
1a8f51e7453 Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usage
2d944e982c4 Merge bitcoin/bitcoin#31285: guix: remove `util-linux`
bcd82b13f46 Remove pkgconfig from toolchain file
319a4e82614 depends: drop sqlite pkgconfig file
fa1177e3d7c refactor: Avoid std::string format strings
a8fe1fd38bf depends: better cleanup after fontconfig
17e79c92607 depends: fully remove libtool archives from Qt build
8ca85651c83 guix: move pkg-config to Linux builds
e3e648cf410 depends: drop pkg-config option from Qt build
0d185bd99f9 doc: update depends doc to prefer .cmake outputs
e546b4e1a0c Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutorial.md
f44e39c9d0d Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for literal format strings
299e2220e95 gen-manpages: implement --skip-missing-binaries
5736d1ddacc tracing: pass if replaced by tx/pkg to tracepoint
a4ec07f1944 doc: add comments for CTxMemPool::ChangeSet
83f814b1d11 Remove m_all_conflicts from SubPackageState
d3c8e7dfb63 Ensure that we don't add duplicate transactions in rbf fuzz tests
d7dc9fd2f7b Move CalculateChunksForRBF() to the mempool changeset
284a1d33f1d Move prioritisation into changeset
446b08b599b Don't distinguish between direct conflicts and all conflicts when doing cluster-size-2-rbf checks
b53041021ab Duplicate transactions are not permitted within a changeset
b447416fddc Public mempool removal methods Assume() no changeset is outstanding
2b30f4d36c8 Make RemoveStaged() private
18829194ca6 Enforce that there is only one changeset at a time
7fb62f7db60 Apply mempool changeset transactions directly into the mempool
34b6c5833d1 Clean up FinalizeSubpackage to avoid workspace-specific information
57983b8add7 Move LimitMempoolSize to take place outside FinalizeSubpackage
01e145b9758 Move changeset from workspace to subpackage
802214c0832 Introduce mempool changesets
87d92fa3401 test: Add unit test coverage of package rbf + prioritisetransaction
15d982f91e6 Add package hash to package-rbf log message
4d668549825 ci: remove util-linux from centos CI
cdf34be7c94 guix: remove util-linux
cbf1a47d606 CheckEphemeralSpends: only compute txid of tx when needed
111465d72dd test: Remove unused attempts parameter from wait_until
5468a23eb9a test: Add check_interval parameter to wait_until
16c87d91fd4 test: Introduce ensure_for helper
a6ca8f32439 fuzz: Fix difficulty target generation in p2p_headers_presync
8610bcef9d0 ci: skip Github CI on branch pushes for forks
ee1128ead84 doc: update stack-clash-protection comment re mingw-w64
bf47448f152 test: drop check for Windows < 10
35b898c47f8 release: target Windows 10 or later
398754e70bc depends: target Windows 10 when building for mingw-w64
ac286e0d1bd doc: Fix grammatical errors in multisig-tutorial.md
fa327c77e34 util: Add ConsumeArithUInt256InRange fuzzing helper
42066f45ff5 Refactor SipHash_32b benchmark to improve accuracy and avoid optimization issues
fe39acf88ff tinyformat: Add compile-time checking for literal format strings
184f34f2d0f util: Support dynamic width & precision in ConstevalFormatString
192dac1d337 [refactor] Cleanup BlockAssembler mempool usage
0bd53d913c1 test: add test for getchaintips behavior with invalid chains
ccd98ea4c88 test: cleanup rpc_getchaintips.py
f5149ddb9b7 validation: mark blocks building on an invalid block as BLOCK_FAILED_CHILD
783cb7337f7 validation: call RecalculateBestHeader in InvalidChainFound
9275e9689a4 rpc: call RecalculateBestHeader as part of reconsiderblock
a51e91783aa validation: add RecalculateBestHeader() function
REVERT: 403c20980ec kernel: Add pure kernel bitcoin-chainstate
REVERT: 2e1b262eff6 kernel: Add functions to get the block hash from a block
REVERT: f0b56a6052a kernel: Add block index utility functions to C header
REVERT: 9393cf98179 kernel: Add function to read block undo data from disk to C header
REVERT: e2ccfba0e3e kernel: Add functions to read block from disk to C header
REVERT: 0559575861c kernel: Add function for copying  block data to C header
REVERT: 7b02e52237e kernel: Add functions for the block validation state to C header
REVERT: fdebacca7ad kernel: Add validation interface to C header
REVERT: f4ea5f49c6d kernel: Add interrupt function to C header
REVERT: 5f4b436aad9 kernel: Add import blocks function to C header
REVERT: c95a28fd80c kernel: Add chainstate load options for in-memory dbs in C header
REVERT: d6360557ef6 kernel: Add options for reindexing in C header
REVERT: a125867b9fe kernel: Add block validation to C header
REVERT: b2b75a0ef73 Kernel: Add chainstate loading to kernel C header
REVERT: d233003ff2a kernel: Add chainstate manager option for setting worker threads
REVERT: 3610be3b138 kernel: Add chainstate manager object to C header
REVERT: c194bea41f6 kernel: Add notifications context option to C header
REVERT: 691d89d846b kerenl: Add chain params context option to C header
REVERT: 407ca750cda kernel: Add kernel library context object
REVERT: ee3c4ea92cd kernel: Add logging to kernel library C header
REVERT: e6c610a7e03 kernel: Introduce initial kernel C header API

git-subtree-dir: libbitcoinkernel-sys/bitcoin
git-subtree-split: 997c2ccc920adb0d1c9d8e82dbe94374cfb3c78b
TheCharlatan added a commit to TheCharlatan/rust-bitcoinkernel that referenced this pull request Dec 4, 2024
@TheCharlatan
Squashed 'libbitcoinkernel-sys/bitcoin/' changes from 403c20980ec..60…
15319cf 
…90df267df

6090df267df kernel: Add pure kernel bitcoin-chainstate
29e3b874303 kernel: Add functions to get the block hash from a block
97d83063cb6 kernel: Add block index utility functions to C header
76ead0878a3 kernel: Add function to read block undo data from disk to C header
94c215c4212 kernel: Add functions to read block from disk to C header
aff05fcbe62 kernel: Add function for copying  block data to C header
a379fbe15eb kernel: Add functions for the block validation state to C header
81db1665213 kernel: Add validation interface to C header
0ee7a5f58a6 kernel: Add interrupt function to C header
f68b3dbf919 kernel: Add import blocks function to C header
503aae9afc5 kernel: Add chainstate load options for in-memory dbs in C header
fa1335fd809 kernel: Add options for reindexing in C header
0eb020f9c82 kernel: Add block validation to C header
5f471729674 Kernel: Add chainstate loading to kernel C header
90949cbb09d kernel: Add chainstate manager option for setting worker threads
a2021b517c6 kernel: Add chainstate manager object to C header
428ea46909b kernel: Add notifications context option to C header
b1f5d450323 kerenl: Add chain params context option to C header
7bb4b412db0 kernel: Add kernel library context object
e4b63d7f5d9 kernel: Add logging to kernel library C header
47bb56b243e kernel: Introduce initial kernel C header API
ff873a20a7f Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
c9a7418a8df Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1
6f24662eb96 Merge bitcoin/bitcoin#31175: rpc: Remove submitblock pre-checks
3867d2421ae Merge bitcoin/bitcoin#31112: Improve parallel script validation error debug logging
8e02b480591 Merge bitcoin/bitcoin#31284: ci: Skip broken Wine64 tests by default
492e1f09943 [validation] merge all ConnectBlock debug logging code paths
b49df703f03 [validation] include all logged information in BlockValidationState
7b267c034fd [validation] Add detailed txin/txout information for script error messages
146a3d54268 [validation] Make script error messages uniform for parallel/single validation
1ac1c33f3f1 [checkqueue] support user-defined return type through std::optional
ebe4cac38bf Merge bitcoin/bitcoin#30991: test: enable running independent functional test sub-tests
19276741007 Merge bitcoin/bitcoin#31387: doc: Use more precise anchor link to codesigning docs
e043618d44d Merge bitcoin/bitcoin#31396: test: simple reordering to reduce run time
a25b892ab1f Merge bitcoin/bitcoin#31386: doc: Use more precise anchor links to Xcode SDK extraction
eb646111cdc Merge bitcoin/bitcoin#31383: test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py
6cd95de2e02 Merge bitcoin/bitcoin#31395: build: Set shared linker flags in toolchain file
abeebccc480 Merge bitcoin/bitcoin#31357: cmake: Improve build script correctness
4c9b13841c4 Merge bitcoin/bitcoin#31402: doc: correct libfuzzer-nosan preset flag
da4f4fac8df Merge bitcoin/bitcoin#31361: cmake, qt: Use absolute paths for includes in MOC-generated files
16b140f225a doc: correct libfuzzer-nosan preset flag
097c66f6148 Merge bitcoin/bitcoin#30039: dbwrapper: Bump LevelDB max file size to 32 MiB to avoid system slowdown from high disk cache flush rate
68daaea0e48 Merge bitcoin/bitcoin#31390: Remove `src/config` directory
14f162dc5c8 Merge bitcoin/bitcoin#31399: ci, macos: Install `pkgconf` Homebrew's package
e2f2698395c ci, macos: Install `pkgconf` Homebrew's package
b73d3319377 dbwrapper: Bump max file size to 32 MiB
62f6d9e1a48 test: simple ordering optimization to reduce runtime
a8e04704f93 build: Set shared linker flags in toolchain file
dbc8ba12f3b Merge bitcoin/bitcoin#31371: doc, test: more ephemeral dust follow-ups
935973b315f Remove `src/config` directory
19f49c7489d doc: Use more precise anchor link to codesigning docs
8bf1b3039cb doc: Use more precise anchor links to Xcode SDK extraction
7590e93bc73 Merge bitcoin/bitcoin#30986: contrib: skip missing binaries in gen-manpages
b2af068825c Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity
144f98db85e Merge bitcoin/bitcoin#31337: build: Fix coverage builds
faa16ed4b9e test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py
efdb49afb9e Merge bitcoin/bitcoin#31323: guix: swap `moreutils` for just `sponge`
37a5c5d8366 doc: update descriptors.md for getdescriptoractivity
ee3ce6a4f4d test: rpc: add no address case for getdescriptoractivity
811f76f3a51 rpc: add getdescriptoractivity
ee6185372fc gen-manpages: Prompt error if no binaries are found
70e20ea024c Merge bitcoin/bitcoin#31172: build: increase minimum supported Windows to 10.0
733317ba943 Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
5a4bc5c0366 Merge bitcoin/bitcoin#31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors
28fd0bc7316 Merge bitcoin/bitcoin#31365: interpreter: Use the same type for SignatureHash in the definition
72ab35a6d09 Merge bitcoin/bitcoin#31221: ci: Split out native fuzz jobs for macOS and windows (take 2)
160799d9135 test: refactor: introduce `create_ephemeral_dust_package` helper
61e18dec306 doc: ephemeral policy: add missing closing double quote
32fc59796f7 rpc: Allow single transaction through submitpackage
3305972f7bf refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
11f3bc229cc refactor: Reserve vectors in fuzz tests
152fefe7a22 refactor: Preallocate PrevectorFillVector(In)Direct without vector resize
a774c7a339c refactor: Fix remaining clang-tidy performance-inefficient-vector errors
f7144b24be0 Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups
c288c790cd9 interpreter: Use the same type for SignatureHash in the definition
b031b7910d6 [ci] Split out native fuzz jobs for macOS and windows
6f4128e3a83 cmake, qt: Use absolute paths for includes in MOC-generated files
ab5c63edcce cmake: Build `secp256k1` only when required
76a3a540a4c cmake: Ensure script correctness when no targets are specified
e8f50c5debe guix: swap moreutils for just sponge
01a7298818d build: Avoid using the `-ffile-prefix-map` compiler option
2638fdb4f93 Merge bitcoin/bitcoin#31338: test: Deduplicate assert_mempool_contents()
73db95c65c1 kernel: Make bitcoin-chainstate's block validation mirror submitblock's
bb53ce9bdae tests: Add functional test for submitting a previously pruned block
1f7fc738255 rpc: Remove submitblock duplicate pre-check
e62a8abd7df rpc: Remove submitblock invalid-duplicate precheck
36dbebafb9b rpc: Remove submitblock coinbase pre-check
17834bd1976 Merge bitcoin/bitcoin#31333: fuzz: Implement G_TEST_GET_FULL_NAME
cf577227888 Merge bitcoin/bitcoin#31335: macOS: swap docs & CI from pkg-config to pkgconf
fe3457ccfff ci: note that we should install pkgconf in future
a0eafc10f94 functional test: Deduplicate assert_mempool_contents()
8d203480b33 doc: migrate from pkg-config to pkgconf in macOS build docs
466e4df3fb8 assert_mempool_contents: assert not duplicates expected
ea5db2f2692 functional: only generate required blocks for test
d033acb6083 fuzz: package_eval: let fuzzer run out input in main tx creation loop
ba35a570c5d CheckEphemeralSpends: return boolean, and set child state and txid outparams
cf0cee1617c func: add note about lack of 1P1C propagation in tree submitpackage
84242903043 unit test: ephemeral_tests is using a dust relay rate, not minrelay
d9cfa5fc4eb CheckEphemeralSpends: no need to iterate inputs if no parent dust
87b26e3dc07 func: rename test_free_relay to test_no_minrelay_fee
e5709a4a41e func: slight elaboration on submitpackage restriction
08e969bd107 RPC: only enforce dust rules on priority when standardness active
ca050d12e76 unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX
7c3490169c9 fuzz: package_eval: move last_tx inside txn ctor
445eaed182a fuzz: use optional status instead of should_rbf_eph_spend
4dfdf615b9d fuzz: remove unused TransactionsDelta validation interface
09ce926e4a1 func: cleanup reorg test comment
768a0c1889e func: cleanup test_dustrelay comments
bedca1cb663 fuzz: Directly place transactions in vector
c041ad6eccb fuzz: explain package eval coin tracking better
bc0d98ea612 fuzz: remove dangling reference to GetEntry
15b6cbf07f5 unit test: make dust index less magical
5fbcfd12b8f unit test: assert txid returned on CheckEphemeralSpends failures
ef94d84b4e4 bench: remove unnecessary CMTxn constructors
c5c10fd317c ephemeral policy doxygen cleanup
dd9044b8d46 ephemeral policy: IWYU
c6859ce2de7 Move+rename GetDustIndexes -> GetDust
22ef95dbe3e Merge bitcoin/bitcoin#31288: Add destroy to BlockTemplate schema
92d3d691f09 fuzz: Implement G_TEST_GET_FULL_NAME
f34fe0806a0 Merge bitcoin/bitcoin#31122: cluster mempool: Implement changeset interface for mempool
b2d952c0f5b Merge bitcoin/bitcoin#31331: doc: add copyright header to p2p_headers_presync
7d3703dec3d doc: add copyright header to p2p_headers_presync
116b8c55736 Merge bitcoin/bitcoin#31213: fuzz: Fix difficulty target generation in `p2p_headers_presync`
15c1f47a005 Merge bitcoin/bitcoin#31327: doc: Correct PR Review Club frequency from weekly to monthly
1209a1082c8 Merge bitcoin/bitcoin#31315: build: Enable -Wbidi-chars=any
ab22726def9 Merge bitcoin/bitcoin#31276: guix: scope pkg-config to Linux only
637f437a164 doc: remove PR Review Club frequency
e1223099584 Merge bitcoin/bitcoin#31317: test: Revert to random path element
2666d83da59 Merge bitcoin/bitcoin#30893: test: Introduce ensure_for helper
faaaf59f71e test: Make g_rng_temp_path rand, not dependent on SeedRandomForTest
746f93b4f0f Merge bitcoin/bitcoin#31307: build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
25fe087de59 rpc: move-only: move ScriptPubKeyDoc to utils
fa80b08fef0 test: Revert to random path element
8f85d36d68a refactor: Clamp worker threads in ChainstateManager constructor
fa7857ccda5 build: Enable -Wbidi-chars=any
b2d53610028 build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
9aa50152c1c Add destroy to BlockTemplate schema
ccc2d3abcd3 Merge bitcoin/bitcoin#31287: refactor: Avoid std::string format strings
62016b32300 Use std::ranges for ephemeral policy checks
3ed930a1f41 Have HasDust and PreCheckValidEphemeralTx take CTransaction
04a614bf9a7 Rename CheckValidEphemeralTx to PreCheckEphemeralTx
85bcfeea235 Merge bitcoin/bitcoin#30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment
2257c6d68fa Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks
380e1f44e8e Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues
1a8f51e7453 Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usage
2d944e982c4 Merge bitcoin/bitcoin#31285: guix: remove `util-linux`
bcd82b13f46 Remove pkgconfig from toolchain file
319a4e82614 depends: drop sqlite pkgconfig file
fa1177e3d7c refactor: Avoid std::string format strings
a8fe1fd38bf depends: better cleanup after fontconfig
17e79c92607 depends: fully remove libtool archives from Qt build
8ca85651c83 guix: move pkg-config to Linux builds
e3e648cf410 depends: drop pkg-config option from Qt build
0d185bd99f9 doc: update depends doc to prefer .cmake outputs
e546b4e1a0c Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutorial.md
f44e39c9d0d Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for literal format strings
299e2220e95 gen-manpages: implement --skip-missing-binaries
5736d1ddacc tracing: pass if replaced by tx/pkg to tracepoint
a4ec07f1944 doc: add comments for CTxMemPool::ChangeSet
83f814b1d11 Remove m_all_conflicts from SubPackageState
d3c8e7dfb63 Ensure that we don't add duplicate transactions in rbf fuzz tests
d7dc9fd2f7b Move CalculateChunksForRBF() to the mempool changeset
284a1d33f1d Move prioritisation into changeset
446b08b599b Don't distinguish between direct conflicts and all conflicts when doing cluster-size-2-rbf checks
b53041021ab Duplicate transactions are not permitted within a changeset
b447416fddc Public mempool removal methods Assume() no changeset is outstanding
2b30f4d36c8 Make RemoveStaged() private
18829194ca6 Enforce that there is only one changeset at a time
7fb62f7db60 Apply mempool changeset transactions directly into the mempool
34b6c5833d1 Clean up FinalizeSubpackage to avoid workspace-specific information
57983b8add7 Move LimitMempoolSize to take place outside FinalizeSubpackage
01e145b9758 Move changeset from workspace to subpackage
802214c0832 Introduce mempool changesets
87d92fa3401 test: Add unit test coverage of package rbf + prioritisetransaction
15d982f91e6 Add package hash to package-rbf log message
fa5e7064597 ci: Skip broken Wine64 tests by default
4d668549825 ci: remove util-linux from centos CI
cdf34be7c94 guix: remove util-linux
cbf1a47d606 CheckEphemeralSpends: only compute txid of tx when needed
111465d72dd test: Remove unused attempts parameter from wait_until
5468a23eb9a test: Add check_interval parameter to wait_until
16c87d91fd4 test: Introduce ensure_for helper
a6ca8f32439 fuzz: Fix difficulty target generation in p2p_headers_presync
8610bcef9d0 ci: skip Github CI on branch pushes for forks
409d0d62937 test: enable running individual independent functional test methods
ee1128ead84 doc: update stack-clash-protection comment re mingw-w64
bf47448f152 test: drop check for Windows < 10
35b898c47f8 release: target Windows 10 or later
398754e70bc depends: target Windows 10 when building for mingw-w64
ac286e0d1bd doc: Fix grammatical errors in multisig-tutorial.md
fa327c77e34 util: Add ConsumeArithUInt256InRange fuzzing helper
42066f45ff5 Refactor SipHash_32b benchmark to improve accuracy and avoid optimization issues
fe39acf88ff tinyformat: Add compile-time checking for literal format strings
184f34f2d0f util: Support dynamic width & precision in ConstevalFormatString
192dac1d337 [refactor] Cleanup BlockAssembler mempool usage
0bd53d913c1 test: add test for getchaintips behavior with invalid chains
ccd98ea4c88 test: cleanup rpc_getchaintips.py
f5149ddb9b7 validation: mark blocks building on an invalid block as BLOCK_FAILED_CHILD
783cb7337f7 validation: call RecalculateBestHeader in InvalidChainFound
9275e9689a4 rpc: call RecalculateBestHeader as part of reconsiderblock
a51e91783aa validation: add RecalculateBestHeader() function
REVERT: 403c20980ec kernel: Add pure kernel bitcoin-chainstate
REVERT: 2e1b262eff6 kernel: Add functions to get the block hash from a block
REVERT: f0b56a6052a kernel: Add block index utility functions to C header
REVERT: 9393cf98179 kernel: Add function to read block undo data from disk to C header
REVERT: e2ccfba0e3e kernel: Add functions to read block from disk to C header
REVERT: 0559575861c kernel: Add function for copying  block data to C header
REVERT: 7b02e52237e kernel: Add functions for the block validation state to C header
REVERT: fdebacca7ad kernel: Add validation interface to C header
REVERT: f4ea5f49c6d kernel: Add interrupt function to C header
REVERT: 5f4b436aad9 kernel: Add import blocks function to C header
REVERT: c95a28fd80c kernel: Add chainstate load options for in-memory dbs in C header
REVERT: d6360557ef6 kernel: Add options for reindexing in C header
REVERT: a125867b9fe kernel: Add block validation to C header
REVERT: b2b75a0ef73 Kernel: Add chainstate loading to kernel C header
REVERT: d233003ff2a kernel: Add chainstate manager option for setting worker threads
REVERT: 3610be3b138 kernel: Add chainstate manager object to C header
REVERT: c194bea41f6 kernel: Add notifications context option to C header
REVERT: 691d89d846b kerenl: Add chain params context option to C header
REVERT: 407ca750cda kernel: Add kernel library context object
REVERT: ee3c4ea92cd kernel: Add logging to kernel library C header
REVERT: e6c610a7e03 kernel: Introduce initial kernel C header API

git-subtree-dir: libbitcoinkernel-sys/bitcoin
git-subtree-split: 6090df267dfece6192b567fed6582445aa811e7f
stickies-v added a commit to stickies-v/py-bitcoinkernel that referenced this pull request Dec 18, 2024
@stickies-v
Squashed 'depend/bitcoin/' changes from 35f8503285..20eec64b5e
f6b6da7 
20eec64b5e kernel: Add pure kernel bitcoin-chainstate
1522ee9596 kernel: Add functions to get the block hash from a block
c543cadc90 kernel: Add block index utility functions to C header
6b5a4fed43 kernel: Add function to read block undo data from disk to C header
6b53c3ba1a kernel: Add functions to read block from disk to C header
7f9908ad99 kernel: Add function for copying  block data to C header
1ab71ac371 kernel: Add functions for the block validation state to C header
508dd4db98 kernel: Add validation interface to C header
a6a658e5f8 kernel: Add interrupt function to C header
253c3cd36f kernel: Add import blocks function to C header
3ed633b6c4 kernel: Add chainstate load options for in-memory dbs in C header
08ec37f8ce kernel: Add options for reindexing in C header
ad0875e397 kernel: Add block validation to C header
2575018d69 Kernel: Add chainstate loading to kernel C header
f5d21c94dc kernel: Add chainstate manager option for setting worker threads
783f56f0a2 kernel: Add chainstate manager object to C header
262039e409 kernel: Add notifications context option to C header
dc0d406dd5 kerenl: Add chain params context option to C header
b5f84de7ad kernel: Add kernel library context object
dad0009c86 kernel: Add logging to kernel library C header
27e25aa941 kernel: Introduce initial kernel C header API
ff873a20a7 Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
c9a7418a8d Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1
6f24662eb9 Merge bitcoin/bitcoin#31175: rpc: Remove submitblock pre-checks
3867d2421a Merge bitcoin/bitcoin#31112: Improve parallel script validation error debug logging
8e02b48059 Merge bitcoin/bitcoin#31284: ci: Skip broken Wine64 tests by default
492e1f0994 [validation] merge all ConnectBlock debug logging code paths
b49df703f0 [validation] include all logged information in BlockValidationState
7b267c034f [validation] Add detailed txin/txout information for script error messages
146a3d5426 [validation] Make script error messages uniform for parallel/single validation
1ac1c33f3f [checkqueue] support user-defined return type through std::optional
ebe4cac38b Merge bitcoin/bitcoin#30991: test: enable running independent functional test sub-tests
1927674100 Merge bitcoin/bitcoin#31387: doc: Use more precise anchor link to codesigning docs
e043618d44 Merge bitcoin/bitcoin#31396: test: simple reordering to reduce run time
a25b892ab1 Merge bitcoin/bitcoin#31386: doc: Use more precise anchor links to Xcode SDK extraction
eb646111cd Merge bitcoin/bitcoin#31383: test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py
6cd95de2e0 Merge bitcoin/bitcoin#31395: build: Set shared linker flags in toolchain file
abeebccc48 Merge bitcoin/bitcoin#31357: cmake: Improve build script correctness
4c9b13841c Merge bitcoin/bitcoin#31402: doc: correct libfuzzer-nosan preset flag
da4f4fac8d Merge bitcoin/bitcoin#31361: cmake, qt: Use absolute paths for includes in MOC-generated files
16b140f225 doc: correct libfuzzer-nosan preset flag
097c66f614 Merge bitcoin/bitcoin#30039: dbwrapper: Bump LevelDB max file size to 32 MiB to avoid system slowdown from high disk cache flush rate
68daaea0e4 Merge bitcoin/bitcoin#31390: Remove `src/config` directory
14f162dc5c Merge bitcoin/bitcoin#31399: ci, macos: Install `pkgconf` Homebrew's package
e2f2698395 ci, macos: Install `pkgconf` Homebrew's package
b73d331937 dbwrapper: Bump max file size to 32 MiB
62f6d9e1a4 test: simple ordering optimization to reduce runtime
a8e04704f9 build: Set shared linker flags in toolchain file
dbc8ba12f3 Merge bitcoin/bitcoin#31371: doc, test: more ephemeral dust follow-ups
935973b315 Remove `src/config` directory
19f49c7489 doc: Use more precise anchor link to codesigning docs
8bf1b3039c doc: Use more precise anchor links to Xcode SDK extraction
7590e93bc7 Merge bitcoin/bitcoin#30986: contrib: skip missing binaries in gen-manpages
b2af068825 Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity
144f98db85 Merge bitcoin/bitcoin#31337: build: Fix coverage builds
faa16ed4b9 test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py
efdb49afb9 Merge bitcoin/bitcoin#31323: guix: swap `moreutils` for just `sponge`
37a5c5d836 doc: update descriptors.md for getdescriptoractivity
ee3ce6a4f4 test: rpc: add no address case for getdescriptoractivity
811f76f3a5 rpc: add getdescriptoractivity
ee6185372f gen-manpages: Prompt error if no binaries are found
70e20ea024 Merge bitcoin/bitcoin#31172: build: increase minimum supported Windows to 10.0
733317ba94 Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
5a4bc5c036 Merge bitcoin/bitcoin#31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors
28fd0bc731 Merge bitcoin/bitcoin#31365: interpreter: Use the same type for SignatureHash in the definition
72ab35a6d0 Merge bitcoin/bitcoin#31221: ci: Split out native fuzz jobs for macOS and windows (take 2)
160799d913 test: refactor: introduce `create_ephemeral_dust_package` helper
61e18dec30 doc: ephemeral policy: add missing closing double quote
32fc59796f rpc: Allow single transaction through submitpackage
3305972f7b refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
11f3bc229c refactor: Reserve vectors in fuzz tests
152fefe7a2 refactor: Preallocate PrevectorFillVector(In)Direct without vector resize
a774c7a339 refactor: Fix remaining clang-tidy performance-inefficient-vector errors
f7144b24be Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups
c288c790cd interpreter: Use the same type for SignatureHash in the definition
b031b7910d [ci] Split out native fuzz jobs for macOS and windows
6f4128e3a8 cmake, qt: Use absolute paths for includes in MOC-generated files
ab5c63edcc cmake: Build `secp256k1` only when required
76a3a540a4 cmake: Ensure script correctness when no targets are specified
e8f50c5deb guix: swap moreutils for just sponge
01a7298818 build: Avoid using the `-ffile-prefix-map` compiler option
2638fdb4f9 Merge bitcoin/bitcoin#31338: test: Deduplicate assert_mempool_contents()
73db95c65c kernel: Make bitcoin-chainstate's block validation mirror submitblock's
bb53ce9bda tests: Add functional test for submitting a previously pruned block
1f7fc73825 rpc: Remove submitblock duplicate pre-check
e62a8abd7d rpc: Remove submitblock invalid-duplicate precheck
36dbebafb9 rpc: Remove submitblock coinbase pre-check
17834bd197 Merge bitcoin/bitcoin#31333: fuzz: Implement G_TEST_GET_FULL_NAME
cf57722788 Merge bitcoin/bitcoin#31335: macOS: swap docs & CI from pkg-config to pkgconf
fe3457ccff ci: note that we should install pkgconf in future
a0eafc10f9 functional test: Deduplicate assert_mempool_contents()
8d203480b3 doc: migrate from pkg-config to pkgconf in macOS build docs
466e4df3fb assert_mempool_contents: assert not duplicates expected
ea5db2f269 functional: only generate required blocks for test
d033acb608 fuzz: package_eval: let fuzzer run out input in main tx creation loop
ba35a570c5 CheckEphemeralSpends: return boolean, and set child state and txid outparams
cf0cee1617 func: add note about lack of 1P1C propagation in tree submitpackage
8424290304 unit test: ephemeral_tests is using a dust relay rate, not minrelay
d9cfa5fc4e CheckEphemeralSpends: no need to iterate inputs if no parent dust
87b26e3dc0 func: rename test_free_relay to test_no_minrelay_fee
e5709a4a41 func: slight elaboration on submitpackage restriction
08e969bd10 RPC: only enforce dust rules on priority when standardness active
ca050d12e7 unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX
7c3490169c fuzz: package_eval: move last_tx inside txn ctor
445eaed182 fuzz: use optional status instead of should_rbf_eph_spend
4dfdf615b9 fuzz: remove unused TransactionsDelta validation interface
09ce926e4a func: cleanup reorg test comment
768a0c1889 func: cleanup test_dustrelay comments
bedca1cb66 fuzz: Directly place transactions in vector
c041ad6ecc fuzz: explain package eval coin tracking better
bc0d98ea61 fuzz: remove dangling reference to GetEntry
15b6cbf07f unit test: make dust index less magical
5fbcfd12b8 unit test: assert txid returned on CheckEphemeralSpends failures
ef94d84b4e bench: remove unnecessary CMTxn constructors
c5c10fd317 ephemeral policy doxygen cleanup
dd9044b8d4 ephemeral policy: IWYU
c6859ce2de Move+rename GetDustIndexes -> GetDust
22ef95dbe3 Merge bitcoin/bitcoin#31288: Add destroy to BlockTemplate schema
92d3d691f0 fuzz: Implement G_TEST_GET_FULL_NAME
f34fe0806a Merge bitcoin/bitcoin#31122: cluster mempool: Implement changeset interface for mempool
b2d952c0f5 Merge bitcoin/bitcoin#31331: doc: add copyright header to p2p_headers_presync
7d3703dec3 doc: add copyright header to p2p_headers_presync
116b8c5573 Merge bitcoin/bitcoin#31213: fuzz: Fix difficulty target generation in `p2p_headers_presync`
15c1f47a00 Merge bitcoin/bitcoin#31327: doc: Correct PR Review Club frequency from weekly to monthly
1209a1082c Merge bitcoin/bitcoin#31315: build: Enable -Wbidi-chars=any
ab22726def Merge bitcoin/bitcoin#31276: guix: scope pkg-config to Linux only
637f437a16 doc: remove PR Review Club frequency
e122309958 Merge bitcoin/bitcoin#31317: test: Revert to random path element
2666d83da5 Merge bitcoin/bitcoin#30893: test: Introduce ensure_for helper
faaaf59f71 test: Make g_rng_temp_path rand, not dependent on SeedRandomForTest
746f93b4f0 Merge bitcoin/bitcoin#31307: build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
25fe087de5 rpc: move-only: move ScriptPubKeyDoc to utils
fa80b08fef test: Revert to random path element
8f85d36d68 refactor: Clamp worker threads in ChainstateManager constructor
fa7857ccda build: Enable -Wbidi-chars=any
b2d5361002 build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
9aa50152c1 Add destroy to BlockTemplate schema
ccc2d3abcd Merge bitcoin/bitcoin#31287: refactor: Avoid std::string format strings
62016b3230 Use std::ranges for ephemeral policy checks
3ed930a1f4 Have HasDust and PreCheckValidEphemeralTx take CTransaction
04a614bf9a Rename CheckValidEphemeralTx to PreCheckEphemeralTx
85bcfeea23 Merge bitcoin/bitcoin#30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment
2257c6d68f Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks
380e1f44e8 Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues
1a8f51e745 Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usage
2d944e982c Merge bitcoin/bitcoin#31285: guix: remove `util-linux`
bcd82b13f4 Remove pkgconfig from toolchain file
319a4e8261 depends: drop sqlite pkgconfig file
fa1177e3d7 refactor: Avoid std::string format strings
a8fe1fd38b depends: better cleanup after fontconfig
17e79c9260 depends: fully remove libtool archives from Qt build
8ca85651c8 guix: move pkg-config to Linux builds
e3e648cf41 depends: drop pkg-config option from Qt build
0d185bd99f doc: update depends doc to prefer .cmake outputs
e546b4e1a0 Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutorial.md
f44e39c9d0 Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for literal format strings
299e2220e9 gen-manpages: implement --skip-missing-binaries
5736d1ddac tracing: pass if replaced by tx/pkg to tracepoint
a4ec07f194 doc: add comments for CTxMemPool::ChangeSet
83f814b1d1 Remove m_all_conflicts from SubPackageState
d3c8e7dfb6 Ensure that we don't add duplicate transactions in rbf fuzz tests
d7dc9fd2f7 Move CalculateChunksForRBF() to the mempool changeset
284a1d33f1 Move prioritisation into changeset
446b08b599 Don't distinguish between direct conflicts and all conflicts when doing cluster-size-2-rbf checks
b53041021a Duplicate transactions are not permitted within a changeset
b447416fdd Public mempool removal methods Assume() no changeset is outstanding
2b30f4d36c Make RemoveStaged() private
18829194ca Enforce that there is only one changeset at a time
7fb62f7db6 Apply mempool changeset transactions directly into the mempool
34b6c5833d Clean up FinalizeSubpackage to avoid workspace-specific information
57983b8add Move LimitMempoolSize to take place outside FinalizeSubpackage
01e145b975 Move changeset from workspace to subpackage
802214c083 Introduce mempool changesets
87d92fa340 test: Add unit test coverage of package rbf + prioritisetransaction
15d982f91e Add package hash to package-rbf log message
fa5e706459 ci: Skip broken Wine64 tests by default
4d66854982 ci: remove util-linux from centos CI
cdf34be7c9 guix: remove util-linux
cbf1a47d60 CheckEphemeralSpends: only compute txid of tx when needed
111465d72d test: Remove unused attempts parameter from wait_until
5468a23eb9 test: Add check_interval parameter to wait_until
16c87d91fd test: Introduce ensure_for helper
a6ca8f3243 fuzz: Fix difficulty target generation in p2p_headers_presync
8610bcef9d ci: skip Github CI on branch pushes for forks
409d0d6293 test: enable running individual independent functional test methods
ee1128ead8 doc: update stack-clash-protection comment re mingw-w64
bf47448f15 test: drop check for Windows < 10
35b898c47f release: target Windows 10 or later
398754e70b depends: target Windows 10 when building for mingw-w64
ac286e0d1b doc: Fix grammatical errors in multisig-tutorial.md
fa327c77e3 util: Add ConsumeArithUInt256InRange fuzzing helper
42066f45ff Refactor SipHash_32b benchmark to improve accuracy and avoid optimization issues
fe39acf88f tinyformat: Add compile-time checking for literal format strings
184f34f2d0 util: Support dynamic width & precision in ConstevalFormatString
192dac1d33 [refactor] Cleanup BlockAssembler mempool usage
0bd53d913c test: add test for getchaintips behavior with invalid chains
ccd98ea4c8 test: cleanup rpc_getchaintips.py
f5149ddb9b validation: mark blocks building on an invalid block as BLOCK_FAILED_CHILD
783cb7337f validation: call RecalculateBestHeader in InvalidChainFound
9275e9689a rpc: call RecalculateBestHeader as part of reconsiderblock
a51e91783a validation: add RecalculateBestHeader() function
REVERT: 35f8503285 kernel: Add pure kernel bitcoin-chainstate
REVERT: 84eb1f952c kernel: Add functions to get the block hash from a block
REVERT: 575cb5a033 kernel: Add block index utility functions to C header
REVERT: 4c433defd3 kernel: Add function to read block undo data from disk to C header
REVERT: 83e48e021b kernel: Add functions to read block from disk to C header
REVERT: a4381c560f kernel: Add function for copying  block data to C header
REVERT: d3e84ac5a6 kernel: Add functions for the block validation state to C header
REVERT: deb5b4a5f5 kernel: Add validation interface to C header
REVERT: f4ea5f49c6 kernel: Add interrupt function to C header
REVERT: 5f4b436aad kernel: Add import blocks function to C header
REVERT: c95a28fd80 kernel: Add chainstate load options for in-memory dbs in C header
REVERT: d6360557ef kernel: Add options for reindexing in C header
REVERT: a125867b9f kernel: Add block validation to C header
REVERT: b2b75a0ef7 Kernel: Add chainstate loading to kernel C header
REVERT: d233003ff2 kernel: Add chainstate manager option for setting worker threads
REVERT: 3610be3b13 kernel: Add chainstate manager object to C header
REVERT: c194bea41f kernel: Add notifications context option to C header
REVERT: 691d89d846 kerenl: Add chain params context option to C header
REVERT: 407ca750cd kernel: Add kernel library context object
REVERT: ee3c4ea92c kernel: Add logging to kernel library C header
REVERT: e6c610a7e0 kernel: Introduce initial kernel C header API

git-subtree-dir: depend/bitcoin
git-subtree-split: 20eec64b5e417cac8c68100826c0adf2152a49eb
stickies-v added a commit to stickies-v/py-bitcoinkernel that referenced this pull request Dec 18, 2024
@stickies-v
Squashed 'depend/bitcoin/' changes from 35f8503285..20eec64b5e
6816a65 
20eec64b5e kernel: Add pure kernel bitcoin-chainstate
1522ee9596 kernel: Add functions to get the block hash from a block
c543cadc90 kernel: Add block index utility functions to C header
6b5a4fed43 kernel: Add function to read block undo data from disk to C header
6b53c3ba1a kernel: Add functions to read block from disk to C header
7f9908ad99 kernel: Add function for copying  block data to C header
1ab71ac371 kernel: Add functions for the block validation state to C header
508dd4db98 kernel: Add validation interface to C header
a6a658e5f8 kernel: Add interrupt function to C header
253c3cd36f kernel: Add import blocks function to C header
3ed633b6c4 kernel: Add chainstate load options for in-memory dbs in C header
08ec37f8ce kernel: Add options for reindexing in C header
ad0875e397 kernel: Add block validation to C header
2575018d69 Kernel: Add chainstate loading to kernel C header
f5d21c94dc kernel: Add chainstate manager option for setting worker threads
783f56f0a2 kernel: Add chainstate manager object to C header
262039e409 kernel: Add notifications context option to C header
dc0d406dd5 kerenl: Add chain params context option to C header
b5f84de7ad kernel: Add kernel library context object
dad0009c86 kernel: Add logging to kernel library C header
27e25aa941 kernel: Introduce initial kernel C header API
ff873a20a7 Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
c9a7418a8d Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1
6f24662eb9 Merge bitcoin/bitcoin#31175: rpc: Remove submitblock pre-checks
3867d2421a Merge bitcoin/bitcoin#31112: Improve parallel script validation error debug logging
8e02b48059 Merge bitcoin/bitcoin#31284: ci: Skip broken Wine64 tests by default
492e1f0994 [validation] merge all ConnectBlock debug logging code paths
b49df703f0 [validation] include all logged information in BlockValidationState
7b267c034f [validation] Add detailed txin/txout information for script error messages
146a3d5426 [validation] Make script error messages uniform for parallel/single validation
1ac1c33f3f [checkqueue] support user-defined return type through std::optional
ebe4cac38b Merge bitcoin/bitcoin#30991: test: enable running independent functional test sub-tests
1927674100 Merge bitcoin/bitcoin#31387: doc: Use more precise anchor link to codesigning docs
e043618d44 Merge bitcoin/bitcoin#31396: test: simple reordering to reduce run time
a25b892ab1 Merge bitcoin/bitcoin#31386: doc: Use more precise anchor links to Xcode SDK extraction
eb646111cd Merge bitcoin/bitcoin#31383: test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py
6cd95de2e0 Merge bitcoin/bitcoin#31395: build: Set shared linker flags in toolchain file
abeebccc48 Merge bitcoin/bitcoin#31357: cmake: Improve build script correctness
4c9b13841c Merge bitcoin/bitcoin#31402: doc: correct libfuzzer-nosan preset flag
da4f4fac8d Merge bitcoin/bitcoin#31361: cmake, qt: Use absolute paths for includes in MOC-generated files
16b140f225 doc: correct libfuzzer-nosan preset flag
097c66f614 Merge bitcoin/bitcoin#30039: dbwrapper: Bump LevelDB max file size to 32 MiB to avoid system slowdown from high disk cache flush rate
68daaea0e4 Merge bitcoin/bitcoin#31390: Remove `src/config` directory
14f162dc5c Merge bitcoin/bitcoin#31399: ci, macos: Install `pkgconf` Homebrew's package
e2f2698395 ci, macos: Install `pkgconf` Homebrew's package
b73d331937 dbwrapper: Bump max file size to 32 MiB
62f6d9e1a4 test: simple ordering optimization to reduce runtime
a8e04704f9 build: Set shared linker flags in toolchain file
dbc8ba12f3 Merge bitcoin/bitcoin#31371: doc, test: more ephemeral dust follow-ups
935973b315 Remove `src/config` directory
19f49c7489 doc: Use more precise anchor link to codesigning docs
8bf1b3039c doc: Use more precise anchor links to Xcode SDK extraction
7590e93bc7 Merge bitcoin/bitcoin#30986: contrib: skip missing binaries in gen-manpages
b2af068825 Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity
144f98db85 Merge bitcoin/bitcoin#31337: build: Fix coverage builds
faa16ed4b9 test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py
efdb49afb9 Merge bitcoin/bitcoin#31323: guix: swap `moreutils` for just `sponge`
37a5c5d836 doc: update descriptors.md for getdescriptoractivity
ee3ce6a4f4 test: rpc: add no address case for getdescriptoractivity
811f76f3a5 rpc: add getdescriptoractivity
ee6185372f gen-manpages: Prompt error if no binaries are found
70e20ea024 Merge bitcoin/bitcoin#31172: build: increase minimum supported Windows to 10.0
733317ba94 Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
5a4bc5c036 Merge bitcoin/bitcoin#31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors
28fd0bc731 Merge bitcoin/bitcoin#31365: interpreter: Use the same type for SignatureHash in the definition
72ab35a6d0 Merge bitcoin/bitcoin#31221: ci: Split out native fuzz jobs for macOS and windows (take 2)
160799d913 test: refactor: introduce `create_ephemeral_dust_package` helper
61e18dec30 doc: ephemeral policy: add missing closing double quote
32fc59796f rpc: Allow single transaction through submitpackage
3305972f7b refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
11f3bc229c refactor: Reserve vectors in fuzz tests
152fefe7a2 refactor: Preallocate PrevectorFillVector(In)Direct without vector resize
a774c7a339 refactor: Fix remaining clang-tidy performance-inefficient-vector errors
f7144b24be Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups
c288c790cd interpreter: Use the same type for SignatureHash in the definition
b031b7910d [ci] Split out native fuzz jobs for macOS and windows
6f4128e3a8 cmake, qt: Use absolute paths for includes in MOC-generated files
ab5c63edcc cmake: Build `secp256k1` only when required
76a3a540a4 cmake: Ensure script correctness when no targets are specified
e8f50c5deb guix: swap moreutils for just sponge
01a7298818 build: Avoid using the `-ffile-prefix-map` compiler option
2638fdb4f9 Merge bitcoin/bitcoin#31338: test: Deduplicate assert_mempool_contents()
73db95c65c kernel: Make bitcoin-chainstate's block validation mirror submitblock's
bb53ce9bda tests: Add functional test for submitting a previously pruned block
1f7fc73825 rpc: Remove submitblock duplicate pre-check
e62a8abd7d rpc: Remove submitblock invalid-duplicate precheck
36dbebafb9 rpc: Remove submitblock coinbase pre-check
17834bd197 Merge bitcoin/bitcoin#31333: fuzz: Implement G_TEST_GET_FULL_NAME
cf57722788 Merge bitcoin/bitcoin#31335: macOS: swap docs & CI from pkg-config to pkgconf
fe3457ccff ci: note that we should install pkgconf in future
a0eafc10f9 functional test: Deduplicate assert_mempool_contents()
8d203480b3 doc: migrate from pkg-config to pkgconf in macOS build docs
466e4df3fb assert_mempool_contents: assert not duplicates expected
ea5db2f269 functional: only generate required blocks for test
d033acb608 fuzz: package_eval: let fuzzer run out input in main tx creation loop
ba35a570c5 CheckEphemeralSpends: return boolean, and set child state and txid outparams
cf0cee1617 func: add note about lack of 1P1C propagation in tree submitpackage
8424290304 unit test: ephemeral_tests is using a dust relay rate, not minrelay
d9cfa5fc4e CheckEphemeralSpends: no need to iterate inputs if no parent dust
87b26e3dc0 func: rename test_free_relay to test_no_minrelay_fee
e5709a4a41 func: slight elaboration on submitpackage restriction
08e969bd10 RPC: only enforce dust rules on priority when standardness active
ca050d12e7 unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX
7c3490169c fuzz: package_eval: move last_tx inside txn ctor
445eaed182 fuzz: use optional status instead of should_rbf_eph_spend
4dfdf615b9 fuzz: remove unused TransactionsDelta validation interface
09ce926e4a func: cleanup reorg test comment
768a0c1889 func: cleanup test_dustrelay comments
bedca1cb66 fuzz: Directly place transactions in vector
c041ad6ecc fuzz: explain package eval coin tracking better
bc0d98ea61 fuzz: remove dangling reference to GetEntry
15b6cbf07f unit test: make dust index less magical
5fbcfd12b8 unit test: assert txid returned on CheckEphemeralSpends failures
ef94d84b4e bench: remove unnecessary CMTxn constructors
c5c10fd317 ephemeral policy doxygen cleanup
dd9044b8d4 ephemeral policy: IWYU
c6859ce2de Move+rename GetDustIndexes -> GetDust
22ef95dbe3 Merge bitcoin/bitcoin#31288: Add destroy to BlockTemplate schema
92d3d691f0 fuzz: Implement G_TEST_GET_FULL_NAME
f34fe0806a Merge bitcoin/bitcoin#31122: cluster mempool: Implement changeset interface for mempool
b2d952c0f5 Merge bitcoin/bitcoin#31331: doc: add copyright header to p2p_headers_presync
7d3703dec3 doc: add copyright header to p2p_headers_presync
116b8c5573 Merge bitcoin/bitcoin#31213: fuzz: Fix difficulty target generation in `p2p_headers_presync`
15c1f47a00 Merge bitcoin/bitcoin#31327: doc: Correct PR Review Club frequency from weekly to monthly
1209a1082c Merge bitcoin/bitcoin#31315: build: Enable -Wbidi-chars=any
ab22726def Merge bitcoin/bitcoin#31276: guix: scope pkg-config to Linux only
637f437a16 doc: remove PR Review Club frequency
e122309958 Merge bitcoin/bitcoin#31317: test: Revert to random path element
2666d83da5 Merge bitcoin/bitcoin#30893: test: Introduce ensure_for helper
faaaf59f71 test: Make g_rng_temp_path rand, not dependent on SeedRandomForTest
746f93b4f0 Merge bitcoin/bitcoin#31307: build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
25fe087de5 rpc: move-only: move ScriptPubKeyDoc to utils
fa80b08fef test: Revert to random path element
8f85d36d68 refactor: Clamp worker threads in ChainstateManager constructor
fa7857ccda build: Enable -Wbidi-chars=any
b2d5361002 build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
9aa50152c1 Add destroy to BlockTemplate schema
ccc2d3abcd Merge bitcoin/bitcoin#31287: refactor: Avoid std::string format strings
62016b3230 Use std::ranges for ephemeral policy checks
3ed930a1f4 Have HasDust and PreCheckValidEphemeralTx take CTransaction
04a614bf9a Rename CheckValidEphemeralTx to PreCheckEphemeralTx
85bcfeea23 Merge bitcoin/bitcoin#30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment
2257c6d68f Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks
380e1f44e8 Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues
1a8f51e745 Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usage
2d944e982c Merge bitcoin/bitcoin#31285: guix: remove `util-linux`
bcd82b13f4 Remove pkgconfig from toolchain file
319a4e8261 depends: drop sqlite pkgconfig file
fa1177e3d7 refactor: Avoid std::string format strings
a8fe1fd38b depends: better cleanup after fontconfig
17e79c9260 depends: fully remove libtool archives from Qt build
8ca85651c8 guix: move pkg-config to Linux builds
e3e648cf41 depends: drop pkg-config option from Qt build
0d185bd99f doc: update depends doc to prefer .cmake outputs
e546b4e1a0 Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutorial.md
f44e39c9d0 Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for literal format strings
299e2220e9 gen-manpages: implement --skip-missing-binaries
5736d1ddac tracing: pass if replaced by tx/pkg to tracepoint
a4ec07f194 doc: add comments for CTxMemPool::ChangeSet
83f814b1d1 Remove m_all_conflicts from SubPackageState
d3c8e7dfb6 Ensure that we don't add duplicate transactions in rbf fuzz tests
d7dc9fd2f7 Move CalculateChunksForRBF() to the mempool changeset
284a1d33f1 Move prioritisation into changeset
446b08b599 Don't distinguish between direct conflicts and all conflicts when doing cluster-size-2-rbf checks
b53041021a Duplicate transactions are not permitted within a changeset
b447416fdd Public mempool removal methods Assume() no changeset is outstanding
2b30f4d36c Make RemoveStaged() private
18829194ca Enforce that there is only one changeset at a time
7fb62f7db6 Apply mempool changeset transactions directly into the mempool
34b6c5833d Clean up FinalizeSubpackage to avoid workspace-specific information
57983b8add Move LimitMempoolSize to take place outside FinalizeSubpackage
01e145b975 Move changeset from workspace to subpackage
802214c083 Introduce mempool changesets
87d92fa340 test: Add unit test coverage of package rbf + prioritisetransaction
15d982f91e Add package hash to package-rbf log message
fa5e706459 ci: Skip broken Wine64 tests by default
4d66854982 ci: remove util-linux from centos CI
cdf34be7c9 guix: remove util-linux
cbf1a47d60 CheckEphemeralSpends: only compute txid of tx when needed
111465d72d test: Remove unused attempts parameter from wait_until
5468a23eb9 test: Add check_interval parameter to wait_until
16c87d91fd test: Introduce ensure_for helper
a6ca8f3243 fuzz: Fix difficulty target generation in p2p_headers_presync
8610bcef9d ci: skip Github CI on branch pushes for forks
409d0d6293 test: enable running individual independent functional test methods
ee1128ead8 doc: update stack-clash-protection comment re mingw-w64
bf47448f15 test: drop check for Windows < 10
35b898c47f release: target Windows 10 or later
398754e70b depends: target Windows 10 when building for mingw-w64
ac286e0d1b doc: Fix grammatical errors in multisig-tutorial.md
fa327c77e3 util: Add ConsumeArithUInt256InRange fuzzing helper
42066f45ff Refactor SipHash_32b benchmark to improve accuracy and avoid optimization issues
fe39acf88f tinyformat: Add compile-time checking for literal format strings
184f34f2d0 util: Support dynamic width & precision in ConstevalFormatString
192dac1d33 [refactor] Cleanup BlockAssembler mempool usage
0bd53d913c test: add test for getchaintips behavior with invalid chains
ccd98ea4c8 test: cleanup rpc_getchaintips.py
f5149ddb9b validation: mark blocks building on an invalid block as BLOCK_FAILED_CHILD
783cb7337f validation: call RecalculateBestHeader in InvalidChainFound
9275e9689a rpc: call RecalculateBestHeader as part of reconsiderblock
a51e91783a validation: add RecalculateBestHeader() function
REVERT: 35f8503285 kernel: Add pure kernel bitcoin-chainstate
REVERT: 84eb1f952c kernel: Add functions to get the block hash from a block
REVERT: 575cb5a033 kernel: Add block index utility functions to C header
REVERT: 4c433defd3 kernel: Add function to read block undo data from disk to C header
REVERT: 83e48e021b kernel: Add functions to read block from disk to C header
REVERT: a4381c560f kernel: Add function for copying  block data to C header
REVERT: d3e84ac5a6 kernel: Add functions for the block validation state to C header
REVERT: deb5b4a5f5 kernel: Add validation interface to C header
REVERT: f4ea5f49c6 kernel: Add interrupt function to C header
REVERT: 5f4b436aad kernel: Add import blocks function to C header
REVERT: c95a28fd80 kernel: Add chainstate load options for in-memory dbs in C header
REVERT: d6360557ef kernel: Add options for reindexing in C header
REVERT: a125867b9f kernel: Add block validation to C header
REVERT: b2b75a0ef7 Kernel: Add chainstate loading to kernel C header
REVERT: d233003ff2 kernel: Add chainstate manager option for setting worker threads
REVERT: 3610be3b13 kernel: Add chainstate manager object to C header
REVERT: c194bea41f kernel: Add notifications context option to C header
REVERT: 691d89d846 kerenl: Add chain params context option to C header
REVERT: 407ca750cd kernel: Add kernel library context object
REVERT: ee3c4ea92c kernel: Add logging to kernel library C header
REVERT: e6c610a7e0 kernel: Introduce initial kernel C header API

git-subtree-dir: depend/bitcoin
git-subtree-split: 20eec64b5e417cac8c68100826c0adf2152a49eb
stickies-v added a commit to stickies-v/py-bitcoinkernel that referenced this pull request Dec 18, 2024
@stickies-v
Squashed 'depend/bitcoin/' changes from 35f8503285..20eec64b5e
de777e8 
20eec64b5e kernel: Add pure kernel bitcoin-chainstate
1522ee9596 kernel: Add functions to get the block hash from a block
c543cadc90 kernel: Add block index utility functions to C header
6b5a4fed43 kernel: Add function to read block undo data from disk to C header
6b53c3ba1a kernel: Add functions to read block from disk to C header
7f9908ad99 kernel: Add function for copying  block data to C header
1ab71ac371 kernel: Add functions for the block validation state to C header
508dd4db98 kernel: Add validation interface to C header
a6a658e5f8 kernel: Add interrupt function to C header
253c3cd36f kernel: Add import blocks function to C header
3ed633b6c4 kernel: Add chainstate load options for in-memory dbs in C header
08ec37f8ce kernel: Add options for reindexing in C header
ad0875e397 kernel: Add block validation to C header
2575018d69 Kernel: Add chainstate loading to kernel C header
f5d21c94dc kernel: Add chainstate manager option for setting worker threads
783f56f0a2 kernel: Add chainstate manager object to C header
262039e409 kernel: Add notifications context option to C header
dc0d406dd5 kerenl: Add chain params context option to C header
b5f84de7ad kernel: Add kernel library context object
dad0009c86 kernel: Add logging to kernel library C header
27e25aa941 kernel: Introduce initial kernel C header API
ff873a20a7 Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
c9a7418a8d Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1
6f24662eb9 Merge bitcoin/bitcoin#31175: rpc: Remove submitblock pre-checks
3867d2421a Merge bitcoin/bitcoin#31112: Improve parallel script validation error debug logging
8e02b48059 Merge bitcoin/bitcoin#31284: ci: Skip broken Wine64 tests by default
492e1f0994 [validation] merge all ConnectBlock debug logging code paths
b49df703f0 [validation] include all logged information in BlockValidationState
7b267c034f [validation] Add detailed txin/txout information for script error messages
146a3d5426 [validation] Make script error messages uniform for parallel/single validation
1ac1c33f3f [checkqueue] support user-defined return type through std::optional
ebe4cac38b Merge bitcoin/bitcoin#30991: test: enable running independent functional test sub-tests
1927674100 Merge bitcoin/bitcoin#31387: doc: Use more precise anchor link to codesigning docs
e043618d44 Merge bitcoin/bitcoin#31396: test: simple reordering to reduce run time
a25b892ab1 Merge bitcoin/bitcoin#31386: doc: Use more precise anchor links to Xcode SDK extraction
eb646111cd Merge bitcoin/bitcoin#31383: test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py
6cd95de2e0 Merge bitcoin/bitcoin#31395: build: Set shared linker flags in toolchain file
abeebccc48 Merge bitcoin/bitcoin#31357: cmake: Improve build script correctness
4c9b13841c Merge bitcoin/bitcoin#31402: doc: correct libfuzzer-nosan preset flag
da4f4fac8d Merge bitcoin/bitcoin#31361: cmake, qt: Use absolute paths for includes in MOC-generated files
16b140f225 doc: correct libfuzzer-nosan preset flag
097c66f614 Merge bitcoin/bitcoin#30039: dbwrapper: Bump LevelDB max file size to 32 MiB to avoid system slowdown from high disk cache flush rate
68daaea0e4 Merge bitcoin/bitcoin#31390: Remove `src/config` directory
14f162dc5c Merge bitcoin/bitcoin#31399: ci, macos: Install `pkgconf` Homebrew's package
e2f2698395 ci, macos: Install `pkgconf` Homebrew's package
b73d331937 dbwrapper: Bump max file size to 32 MiB
62f6d9e1a4 test: simple ordering optimization to reduce runtime
a8e04704f9 build: Set shared linker flags in toolchain file
dbc8ba12f3 Merge bitcoin/bitcoin#31371: doc, test: more ephemeral dust follow-ups
935973b315 Remove `src/config` directory
19f49c7489 doc: Use more precise anchor link to codesigning docs
8bf1b3039c doc: Use more precise anchor links to Xcode SDK extraction
7590e93bc7 Merge bitcoin/bitcoin#30986: contrib: skip missing binaries in gen-manpages
b2af068825 Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity
144f98db85 Merge bitcoin/bitcoin#31337: build: Fix coverage builds
faa16ed4b9 test: Add missing node.setmocktime(self.mocktime) to p2p_ibd_stalling.py
efdb49afb9 Merge bitcoin/bitcoin#31323: guix: swap `moreutils` for just `sponge`
37a5c5d836 doc: update descriptors.md for getdescriptoractivity
ee3ce6a4f4 test: rpc: add no address case for getdescriptoractivity
811f76f3a5 rpc: add getdescriptoractivity
ee6185372f gen-manpages: Prompt error if no binaries are found
70e20ea024 Merge bitcoin/bitcoin#31172: build: increase minimum supported Windows to 10.0
733317ba94 Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
5a4bc5c036 Merge bitcoin/bitcoin#31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors
28fd0bc731 Merge bitcoin/bitcoin#31365: interpreter: Use the same type for SignatureHash in the definition
72ab35a6d0 Merge bitcoin/bitcoin#31221: ci: Split out native fuzz jobs for macOS and windows (take 2)
160799d913 test: refactor: introduce `create_ephemeral_dust_package` helper
61e18dec30 doc: ephemeral policy: add missing closing double quote
32fc59796f rpc: Allow single transaction through submitpackage
3305972f7b refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors
11f3bc229c refactor: Reserve vectors in fuzz tests
152fefe7a2 refactor: Preallocate PrevectorFillVector(In)Direct without vector resize
a774c7a339 refactor: Fix remaining clang-tidy performance-inefficient-vector errors
f7144b24be Merge bitcoin/bitcoin#31279: policy: ephemeral dust followups
c288c790cd interpreter: Use the same type for SignatureHash in the definition
b031b7910d [ci] Split out native fuzz jobs for macOS and windows
6f4128e3a8 cmake, qt: Use absolute paths for includes in MOC-generated files
ab5c63edcc cmake: Build `secp256k1` only when required
76a3a540a4 cmake: Ensure script correctness when no targets are specified
e8f50c5deb guix: swap moreutils for just sponge
01a7298818 build: Avoid using the `-ffile-prefix-map` compiler option
2638fdb4f9 Merge bitcoin/bitcoin#31338: test: Deduplicate assert_mempool_contents()
73db95c65c kernel: Make bitcoin-chainstate's block validation mirror submitblock's
bb53ce9bda tests: Add functional test for submitting a previously pruned block
1f7fc73825 rpc: Remove submitblock duplicate pre-check
e62a8abd7d rpc: Remove submitblock invalid-duplicate precheck
36dbebafb9 rpc: Remove submitblock coinbase pre-check
17834bd197 Merge bitcoin/bitcoin#31333: fuzz: Implement G_TEST_GET_FULL_NAME
cf57722788 Merge bitcoin/bitcoin#31335: macOS: swap docs & CI from pkg-config to pkgconf
fe3457ccff ci: note that we should install pkgconf in future
a0eafc10f9 functional test: Deduplicate assert_mempool_contents()
8d203480b3 doc: migrate from pkg-config to pkgconf in macOS build docs
466e4df3fb assert_mempool_contents: assert not duplicates expected
ea5db2f269 functional: only generate required blocks for test
d033acb608 fuzz: package_eval: let fuzzer run out input in main tx creation loop
ba35a570c5 CheckEphemeralSpends: return boolean, and set child state and txid outparams
cf0cee1617 func: add note about lack of 1P1C propagation in tree submitpackage
8424290304 unit test: ephemeral_tests is using a dust relay rate, not minrelay
d9cfa5fc4e CheckEphemeralSpends: no need to iterate inputs if no parent dust
87b26e3dc0 func: rename test_free_relay to test_no_minrelay_fee
e5709a4a41 func: slight elaboration on submitpackage restriction
08e969bd10 RPC: only enforce dust rules on priority when standardness active
ca050d12e7 unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX
7c3490169c fuzz: package_eval: move last_tx inside txn ctor
445eaed182 fuzz: use optional status instead of should_rbf_eph_spend
4dfdf615b9 fuzz: remove unused TransactionsDelta validation interface
09ce926e4a func: cleanup reorg test comment
768a0c1889 func: cleanup test_dustrelay comments
bedca1cb66 fuzz: Directly place transactions in vector
c041ad6ecc fuzz: explain package eval coin tracking better
bc0d98ea61 fuzz: remove dangling reference to GetEntry
15b6cbf07f unit test: make dust index less magical
5fbcfd12b8 unit test: assert txid returned on CheckEphemeralSpends failures
ef94d84b4e bench: remove unnecessary CMTxn constructors
c5c10fd317 ephemeral policy doxygen cleanup
dd9044b8d4 ephemeral policy: IWYU
c6859ce2de Move+rename GetDustIndexes -> GetDust
22ef95dbe3 Merge bitcoin/bitcoin#31288: Add destroy to BlockTemplate schema
92d3d691f0 fuzz: Implement G_TEST_GET_FULL_NAME
f34fe0806a Merge bitcoin/bitcoin#31122: cluster mempool: Implement changeset interface for mempool
b2d952c0f5 Merge bitcoin/bitcoin#31331: doc: add copyright header to p2p_headers_presync
7d3703dec3 doc: add copyright header to p2p_headers_presync
116b8c5573 Merge bitcoin/bitcoin#31213: fuzz: Fix difficulty target generation in `p2p_headers_presync`
15c1f47a00 Merge bitcoin/bitcoin#31327: doc: Correct PR Review Club frequency from weekly to monthly
1209a1082c Merge bitcoin/bitcoin#31315: build: Enable -Wbidi-chars=any
ab22726def Merge bitcoin/bitcoin#31276: guix: scope pkg-config to Linux only
637f437a16 doc: remove PR Review Club frequency
e122309958 Merge bitcoin/bitcoin#31317: test: Revert to random path element
2666d83da5 Merge bitcoin/bitcoin#30893: test: Introduce ensure_for helper
faaaf59f71 test: Make g_rng_temp_path rand, not dependent on SeedRandomForTest
746f93b4f0 Merge bitcoin/bitcoin#31307: build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
25fe087de5 rpc: move-only: move ScriptPubKeyDoc to utils
fa80b08fef test: Revert to random path element
8f85d36d68 refactor: Clamp worker threads in ChainstateManager constructor
fa7857ccda build: Enable -Wbidi-chars=any
b2d5361002 build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
9aa50152c1 Add destroy to BlockTemplate schema
ccc2d3abcd Merge bitcoin/bitcoin#31287: refactor: Avoid std::string format strings
62016b3230 Use std::ranges for ephemeral policy checks
3ed930a1f4 Have HasDust and PreCheckValidEphemeralTx take CTransaction
04a614bf9a Rename CheckValidEphemeralTx to PreCheckEphemeralTx
85bcfeea23 Merge bitcoin/bitcoin#30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment
2257c6d68f Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks
380e1f44e8 Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues
1a8f51e745 Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usage
2d944e982c Merge bitcoin/bitcoin#31285: guix: remove `util-linux`
bcd82b13f4 Remove pkgconfig from toolchain file
319a4e8261 depends: drop sqlite pkgconfig file
fa1177e3d7 refactor: Avoid std::string format strings
a8fe1fd38b depends: better cleanup after fontconfig
17e79c9260 depends: fully remove libtool archives from Qt build
8ca85651c8 guix: move pkg-config to Linux builds
e3e648cf41 depends: drop pkg-config option from Qt build
0d185bd99f doc: update depends doc to prefer .cmake outputs
e546b4e1a0 Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutorial.md
f44e39c9d0 Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for literal format strings
299e2220e9 gen-manpages: implement --skip-missing-binaries
5736d1ddac tracing: pass if replaced by tx/pkg to tracepoint
a4ec07f194 doc: add comments for CTxMemPool::ChangeSet
83f814b1d1 Remove m_all_conflicts from SubPackageState
d3c8e7dfb6 Ensure that we don't add duplicate transactions in rbf fuzz tests
d7dc9fd2f7 Move CalculateChunksForRBF() to the mempool changeset
284a1d33f1 Move prioritisation into changeset
446b08b599 Don't distinguish between direct conflicts and all conflicts when doing cluster-size-2-rbf checks
b53041021a Duplicate transactions are not permitted within a changeset
b447416fdd Public mempool removal methods Assume() no changeset is outstanding
2b30f4d36c Make RemoveStaged() private
18829194ca Enforce that there is only one changeset at a time
7fb62f7db6 Apply mempool changeset transactions directly into the mempool
34b6c5833d Clean up FinalizeSubpackage to avoid workspace-specific information
57983b8add Move LimitMempoolSize to take place outside FinalizeSubpackage
01e145b975 Move changeset from workspace to subpackage
802214c083 Introduce mempool changesets
87d92fa340 test: Add unit test coverage of package rbf + prioritisetransaction
15d982f91e Add package hash to package-rbf log message
fa5e706459 ci: Skip broken Wine64 tests by default
4d66854982 ci: remove util-linux from centos CI
cdf34be7c9 guix: remove util-linux
cbf1a47d60 CheckEphemeralSpends: only compute txid of tx when needed
111465d72d test: Remove unused attempts parameter from wait_until
5468a23eb9 test: Add check_interval parameter to wait_until
16c87d91fd test: Introduce ensure_for helper
a6ca8f3243 fuzz: Fix difficulty target generation in p2p_headers_presync
8610bcef9d ci: skip Github CI on branch pushes for forks
409d0d6293 test: enable running individual independent functional test methods
ee1128ead8 doc: update stack-clash-protection comment re mingw-w64
bf47448f15 test: drop check for Windows < 10
35b898c47f release: target Windows 10 or later
398754e70b depends: target Windows 10 when building for mingw-w64
ac286e0d1b doc: Fix grammatical errors in multisig-tutorial.md
fa327c77e3 util: Add ConsumeArithUInt256InRange fuzzing helper
42066f45ff Refactor SipHash_32b benchmark to improve accuracy and avoid optimization issues
fe39acf88f tinyformat: Add compile-time checking for literal format strings
184f34f2d0 util: Support dynamic width & precision in ConstevalFormatString
192dac1d33 [refactor] Cleanup BlockAssembler mempool usage
0bd53d913c test: add test for getchaintips behavior with invalid chains
ccd98ea4c8 test: cleanup rpc_getchaintips.py
f5149ddb9b validation: mark blocks building on an invalid block as BLOCK_FAILED_CHILD
783cb7337f validation: call RecalculateBestHeader in InvalidChainFound
9275e9689a rpc: call RecalculateBestHeader as part of reconsiderblock
a51e91783a validation: add RecalculateBestHeader() function
REVERT: 35f8503285 kernel: Add pure kernel bitcoin-chainstate
REVERT: 84eb1f952c kernel: Add functions to get the block hash from a block
REVERT: 575cb5a033 kernel: Add block index utility functions to C header
REVERT: 4c433defd3 kernel: Add function to read block undo data from disk to C header
REVERT: 83e48e021b kernel: Add functions to read block from disk to C header
REVERT: a4381c560f kernel: Add function for copying  block data to C header
REVERT: d3e84ac5a6 kernel: Add functions for the block validation state to C header
REVERT: deb5b4a5f5 kernel: Add validation interface to C header
REVERT: f4ea5f49c6 kernel: Add interrupt function to C header
REVERT: 5f4b436aad kernel: Add import blocks function to C header
REVERT: c95a28fd80 kernel: Add chainstate load options for in-memory dbs in C header
REVERT: d6360557ef kernel: Add options for reindexing in C header
REVERT: a125867b9f kernel: Add block validation to C header
REVERT: b2b75a0ef7 Kernel: Add chainstate loading to kernel C header
REVERT: d233003ff2 kernel: Add chainstate manager option for setting worker threads
REVERT: 3610be3b13 kernel: Add chainstate manager object to C header
REVERT: c194bea41f kernel: Add notifications context option to C header
REVERT: 691d89d846 kerenl: Add chain params context option to C header
REVERT: 407ca750cd kernel: Add kernel library context object
REVERT: ee3c4ea92c kernel: Add logging to kernel library C header
REVERT: e6c610a7e0 kernel: Introduce initial kernel C header API

git-subtree-dir: depend/bitcoin
git-subtree-split: 20eec64b5e417cac8c68100826c0adf2152a49eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCharlatan TheCharlatan TheCharlatan approved these changes

@ryanofsky ryanofsky ryanofsky approved these changes

Assignees

@ryanofsky ryanofsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sjors @DrahtBot @ryanofsky @TheCharlatan