Fix missed change to WalletTx structure #9296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK 28f8ae8 |
|
utACK 28f8ae8 |
|
Thanks for noticing! utACK 28f8ae8 |
laanwj
added a commit
that referenced
this pull request
Dec 6, 2016
28f8ae8 Fix missed change to WalletTx structure (Alex Morcos)
|
I should have said credit to @MarcoFalke and @paveljanik for noticing |
|
Posthumous utACK |
|
And posthumous ACK. |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 17, 2018
28f8ae8 Fix missed change to WalletTx structure (Alex Morcos)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
28f8ae8 Fix missed change to WalletTx structure (Alex Morcos)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 25, 2019
28f8ae8 Fix missed change to WalletTx structure (Alex Morcos)
CryptoCentric
added a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
CryptoCentric
added a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
Issues with bitcoin#8580, bitcoin#9296, and dash commits 4838d42 0d3a429 This must be fixed at a later date
This was referenced Feb 26, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
28f8ae8 Fix missed change to WalletTx structure (Alex Morcos)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently causing assert failure every time you try to send a transaction using QT.
These transactions are being committed though, so care needs to be taken with any wallets that may have been subject to this bug.