Skip to content

Commit

Permalink
Merge #65: Auto deploy regtest nodes in background
Browse files Browse the repository at this point in the history
930b0c4 Update CHANGELOG (rajarshimaitra)
cf9f536 Add CI build for new features (rajarshimaitra)
58a624b Add auto backend deployment (rajarshimaitra)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  Fixes #55. I decided to go for one feature flag for each backends as they made dependency management easier. Because different backend will have different dependency, and we don't wanna have redundant ones. Also it makes the commands a little shorter.

  ### Notes to the reviewers

  Right now its not that useful because the backend APIs are not exposed. So I can't really do much other than sync/send in the command line. (unlike testnet we cannot send coins to bdk from outside of local regtest node). So to make it useful in repl mode as described in the issue, we also have to expose the blockchain apis in bdk-cli command in some way (at least the basic stuffs, address, send, generate). Looking for suggestions on this.

  usage looks like this:
  ```
  cargo run --features regtest-rpc -- wallet --descriptor "wpkh(tpubEBr4i6yk5nf5DAaJpsi9N2pPYBeJ7fZ5Z9rmN4977iYLCGco1VyjB9tvvuvYtfZzjD5A8igzgw3HeWeeKFmanHYqksqZXYXGsw5zjnj7KM9/*)" sync
  {}
  ```

  Although I am having trouble connecting to the esplora end of electrs. Not sure whats the issue, will have to look more.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature
  * [x] I've updated `CHANGELOG.md`

ACKs for top commit:
  notmandatory:
    ACK 930b0c4

Tree-SHA512: a308398d30743c049a6c641f1cdcbf0643f11e56323b98a176c86ac237249beb2ac22b2802dd14fda7874a2079aaf25cacf60d082fd57109d6a41cff359b0145
  • Loading branch information
notmandatory committed Apr 28, 2022
2 parents 92d06d6 + 930b0c4 commit bd510e2
Show file tree
Hide file tree
Showing 5 changed files with 535 additions and 39 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/cont_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,19 @@ jobs:
- esplora-reqwest
- compiler
- compact_filters
- rpc
- reserves
- reserves,electrum
- reserves,esplora-ureq
- reserves,compact_filters
- reserves,rpc
- rpc
- electrum,verify
# regtest-* features are experimental and not fully usable
- regtest-bitcoin
- regtest-electrum
- regtest-esplora-ureq
- regtest-esplora-reqwest

steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Re-license to dual MIT and Apache 2.0 and update project name to "Bitcoin Dev Kit"
- Update to bdk and bdk-reserves to `0.17.0`
- Add 'verify' feature flag which enables transaction verification against consensus rules during sync.
- Make `regtest` the default network.
- Add experimental `regtest-*` features to automatically deploy local regtest nodes
(bitcoind, and electrs) while running cli commands.

## [0.4.0]

Expand Down
Loading

0 comments on commit bd510e2

Please sign in to comment.