Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bdk to 0.20.0 #108

Closed
wants to merge 1 commit into from
Closed

Upgrade bdk to 0.20.0 #108

wants to merge 1 commit into from

Conversation

afilini
Copy link
Member

@afilini afilini commented Jul 8, 2022

Description

I'm opening this PR before 0.20.0 is released so that we can provide a git branch ready for testing before we go ahead and publish the library.

Fixes #106

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

@afilini afilini force-pushed the upgrade/bdk-0.20.0 branch 8 times, most recently from 2dcf58b to ae29570 Compare July 8, 2022 13:40
@notmandatory notmandatory added this to the Release 0.6.0 milestone Jul 8, 2022
@afilini afilini mentioned this pull request Jul 8, 2022
Merged
@afilini
Copy link
Member Author

afilini commented Jul 15, 2022

I have a PR for bdk-reserves ready for review, once that goes in and we get a new release I'll update this PR as well

https://github.com/weareseba/bdk-reserves/pull/8

rajarshimaitra
rajarshimaitra reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this up @afilini .. Looks all good to me.. Just few more changes

  • Change bdk version to regular 20.0 than github branch
  • Get bdk-reserves updated..

I tried to push in your branch but I don't have push access there.. So waiting for you to get this out of draft..

Would like to get this one in before #102 ..

@rajarshimaitra
Copy link
Contributor

rajarshimaitra commented Aug 7, 2022 •
edited
Loading

Hi @afilini .. This PR is now ready to be updated after the bdk-reserves upgrade..

Update: I have played the same changes in the #102 here 013daa6.. Closing this one as we can merge everything together with #102 ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajarshimaitra rajarshimaitra rajarshimaitra left review comments

Assignees

@afilini afilini

Labels
None yet
Projects
BDK-CLI Roadmap
Archived in project
Milestone
Release 0.6.0
Development

Successfully merging this pull request may close these issues.

Update to bdk 0.22.0
3 participants
@afilini @rajarshimaitra @notmandatory