Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if psbt is final, before broadcasting #128

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

rajarshimaitra
Copy link
Contributor

Description

Fixes #97

Add a finalizer check before broadcasting psbts.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added this to the Release 0.7.0 milestone Nov 16, 2022
@rajarshimaitra rajarshimaitra self-assigned this Nov 22, 2022
@rajarshimaitra rajarshimaitra mentioned this pull request Jan 9, 2023
6 tasks
@notmandatory
Copy link
Member

notmandatory commented Jan 10, 2023

While I was manually testing I ran into some issues and in the process of making a unit test I ended up rewriting the logic. Mainly I tried to make it easier to read by removing the loop and some of the if/then/else clauses. If this looks OK to you feel free to pull in the commit, or I can push it into your branch. notmandatory@304e3b9

@rajarshimaitra
Copy link
Contributor Author

Yes I briefly checked the logic and looks better than before.. Better to check for malformation also.. Like that you also included tests.. Thanks for this.. Feel free to push it on top of this PR and I will test it out too.. Or we can create a new PR closing this one.. Anything works..

@notmandatory
Copy link
Member

Sounds good I'll push it to your branch and also do a rebase on master branch.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 110be3f

@notmandatory notmandatory merged commit 559e4ed into bitcoindevkit:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Broadcast should tell user to finalize PSBTs
2 participants