Add Wallet and TxBuilder tests using test funded wallet #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
changed the title
notmandatory
changed the title
|
Super cool. If we get a funded wallet with a descriptor I can wrap up #141 |
9 tasks
|
This is on hold until I can get bitcoindevkit/bdk#600 released in Edit: The fixed up |
notmandatory
force-pushed
the
test_funded_wallet
branch
from
acee7c3
to
829c226
Compare
afilini
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
May 6, 2022
…base> e7a56a9 Change wallet::get_funded_wallet to return Wallet<AnyDatabase> (Steve Myers) Pull request description: ### Description Change testing function `wallet::get_funded_wallet` to return `Wallet<AnyDatabase>` instead of `Wallet<MemoryDatabase>`. This will allow us to use this function for testing `bdk-ffi` which only works with `Wallet<AnyDatabase>`. ### Notes to the reviewers This is required to complete bitcoindevkit/bdk-ffi#148. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature * [ ] I've updated `CHANGELOG.md` #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [ ] I'm linking the issue being fixed by this PR ACKs for top commit: afilini: ACK e7a56a9 Tree-SHA512: 47b53ab6dcee63fc7b24666d3cf9a0ad832782081dd2fe92961c8c9b4c302df90db96b0b518af71d6cbc85319434971219100f8cedb35ce7212d944db29a4295
notmandatory
force-pushed
the
test_funded_wallet
branch
3 times, most recently
from
d2a0012
to
7fc1cba
Compare
notmandatory
force-pushed
the
test_funded_wallet
branch
from
7fc1cba
to
e469dcd
Compare
|
This should be merged after #162 . |
8 tasks
I know it looks strange to have such big files with tests at the end, but this is the canonical place to put Rust unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example test using the
bdktest funded wallet. The example test makes sure thebdk-ffiTxBuilderis able to drain a single wallet UTXO to a single address. More tests can be added as we need them in future PRs.Required to complete #141