Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx builder set recipients #186

Merged

Conversation

waterst0ne
Copy link
Contributor

@waterst0ne waterst0ne commented Aug 19, 2022

Description

I just started working on #168 which enables the tx_builder to add a list of recipients instead of iterating over the add_recipient method multiple times.

  • The set_recipients() method replaces the precedent list and overwrites it with the new one.
  • You can always use add_recipient() to append to the list.

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@waterst0ne waterst0ne marked this pull request as ready for review August 19, 2022 16:08
@notmandatory notmandatory added the enhancement New feature or request label Aug 19, 2022
@notmandatory notmandatory added this to the Release 0.9.0 milestone Aug 19, 2022
@thunderbiscuit thunderbiscuit self-requested a review August 19, 2022 16:40
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall just a few small things. But the biggest question is whether we should introduce the breaking change that would have add_recipient() use the AddressAmount type.

CHANGELOG.md Outdated Show resolved Hide resolved
src/bdk.udl Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@notmandatory
Copy link
Member

@waterst0ne oops, it looks like you force pushed an old version somehow. If you need help fixing it back up let me know.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8703803

@notmandatory
Copy link
Member

notmandatory commented Aug 26, 2022

@thunderbiscuit have your requested changes been addressed? if so you'll need to add an approve before we can merge.

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8703803.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants