-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tx builder set recipients #186
Add tx builder set recipients #186
Conversation
d00eba3
to
3ddef9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall just a few small things. But the biggest question is whether we should introduce the breaking change that would have add_recipient()
use the AddressAmount
type.
3ddef9d
to
c6b77c8
Compare
@waterst0ne oops, it looks like you force pushed an old version somehow. If you need help fixing it back up let me know. |
c6b77c8
to
8703803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8703803
@thunderbiscuit have your requested changes been addressed? if so you'll need to add an approve before we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8703803.
Description
I just started working on #168 which enables the
tx_builder
to add a list of recipients instead of iterating over theadd_recipient
method multiple times.set_recipients()
method replaces the precedent list and overwrites it with the new one.add_recipient()
to append to the list.Notes to the reviewers
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md
Bugfixes: