-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TransactionDetails to include confirmation_time #190
Refactor TransactionDetails to include confirmation_time #190
Conversation
cf184ed
to
1b5c613
Compare
81802a2
to
8614d81
Compare
@notmandatory is this ready for review or do you still see it as draft? I'll take a look today if it's ready. |
It's ready to review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK. Small typo in the changelog but that's it. 🚀
Rust-related question: why does confirmation_time here require to be cloned and the others don't? impl From<&bdk::TransactionDetails> for TransactionDetails {
fn from(x: &bdk::TransactionDetails) -> TransactionDetails {
TransactionDetails {
fee: x.fee,
txid: x.txid.to_string(),
received: x.received,
sent: x.sent,
confirmation_time: x.confirmation_time.clone(),
}
}
} |
This is because the other types have the |
8614d81
to
ee095be
Compare
Description
Fixes #180
Notes to the reviewers
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md
Bugfixes: