Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bdk depencency to 0.23.0 #204

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Oct 4, 2022

Description

This PR updates BDK to the latest version, 0.23.0.

Notes to the reviewers

Only merge once bdk 0.23.0 is out. Edit: it now is, and the PR has been updated.

Changelog notice

- Update BDK to latest version 0.23.0 [#204]

[#204](https://github.com/bitcoindevkit/bdk-ffi/pull/204)

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@@ -6,5 +6,5 @@ edition = "2021"
[dependencies]
anyhow = "=1.0.45" # remove after upgrading to next version of uniffi
structopt = "0.3"
uniffi_bindgen = "0.19.5"
uniffi_bindgen = "=0.20.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove pinning here, or just rebase this one after #203 is fixed and merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase once #203 is merged. I fixed it there, so if you can approve it we'll merge right away and rebase this one.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 535fc70

@notmandatory notmandatory merged commit 535fc70 into bitcoindevkit:master Oct 17, 2022
@notmandatory notmandatory mentioned this pull request Oct 19, 2022
13 tasks
@thunderbiscuit thunderbiscuit deleted the bump-bdk-23 branch November 14, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants