Change TxBuilder.drain_to argument to Script instead of address String

[notmandatory]

Description

Change TxBuilder.drain_to() argument to Script instead of address String. Also remove unneeded fn to_script_pubkey() fixes #261.

Notes to the reviewers

This change aligns bdk-ffi with bdk API which also takes a script instead of an address string for the TxBuilder.drain_to().

Changelog notice

• APIs Changed
  • TxBuilder.drain_to() argument is now Script instead of address String.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[thunderbiscuit]

ACK 7d1a450.

How do you feel about fixing up the API docs as we go? Would you prefer we keep all the fixes for one big PR fix every release, or require people update as they open PRs that change the API?

[notmandatory]

How do you feel about fixing up the API docs as we go? Would you prefer we keep all the fixes for one big PR fix every release, or require people update as they open PRs that change the API?

Yes good catch, we should keep the api-docs up to date as we make PR changes. I don't think for this one I only needed to change the method signature for Kotlin since the docs already match the rust docs. Doese it needs updating anywhere else?

[thunderbiscuit]

Yep this is good to go. Ok will keep the docs in mind for future PRs!