Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bdk to alpha 7 #468

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Mar 21, 2024

This PR:

  1. Bumps the Rust bdk library to its latest version, alpha 7, the esplora client to 0.9.0, and the file store to 0.7.0.
    2. Finally closes a long-standing comment/issue where we could not use rustls for the async esplora client, preventing us from building for Android. The commit enabling the feature simply enables it, but does not build the async client itself. This is currently causing runtime issues. Will fix in a further PR.

Notes to the reviewers

This bump was fairly simple.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link

coderabbitai bot commented Mar 21, 2024

Walkthrough

The recent update introduces a new method and variant named Reqwest to the EsploraError interface and enum respectively, within the bdk-ffi module. This enhancement focuses on extending error handling capabilities, specifically catering to errors related to HTTP requests. By integrating Reqwest errors, the update aims to provide more detailed feedback for issues encountered during HTTP interactions, improving the overall robustness and user experience of the Bitcoin development kit.

Changes

Files Change Summary
bdk-ffi/src/bdk.udl
bdk-ffi/src/error.rs
Added Reqwest method and variant to EsploraError, including error message handling and conversion.

Assessment against linked issues

Objective Addressed Explanation
Activate async-https-rustls feature on esplora client

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@thunderbiscuit thunderbiscuit changed the title Bump bdk Bump bdk to alpha 7 Mar 21, 2024
@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Mar 21, 2024

The failure of the Swift tests maybe look like what is referenced in this issue.

If so, it might mean that it's an architecture mix issue. The CI runs on x86_64, but it somehow build for arm64? I know the tests run cleanly on my local M1. Edit: it fails locally too! Yessss!

@reez
Copy link
Collaborator

reez commented Mar 25, 2024

ACK bf39421

changing from macos14 to macos12 did the trick?

@thunderbiscuit
Copy link
Member Author

No changing it didn't solve it unfortunately (but makes more sense so I'm happy it didn't).

We're still getting linker errors for iOS when attempting to use the reqwest dependency.

@thunderbiscuit thunderbiscuit merged commit 06fa9d7 into bitcoindevkit:master Mar 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants