Skip to content

Commit

Permalink
Merge #745: Add tests to improve coverage
Browse files Browse the repository at this point in the history
e65edbf Change parameter name of database in test funcs (Vladimir Fomene)
8830704 Add more test to the database module (Vladimir Fomene)
e06c3f9 Set tx field to none if `include_raw` is false (Vladimir Fomene)

Pull request description:

  ### Description

  This PR add more test to the database module and also fixes certain bugs discovered by the written test. I also amended the name used for the database parameter in the test functions.

  ### Notes to the reviewers

  This contributes to fixing #699

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  rajarshimaitra:
    tACK e65edbf
  danielabrozzoni:
    Code review ACK e65edbf

Tree-SHA512: 1ac1475f7d63f25e94ef21342e6f6e243c34c8c9208d11a5492f224026055da2a96f20be83497c1ba361effff9861f4e68920f98feebaf4b201d205c7030c282
  • Loading branch information
danielabrozzoni committed Sep 22, 2022
2 parents dfeb08f + e65edbf commit 0a7a1f4
Show file tree
Hide file tree
Showing 4 changed files with 390 additions and 56 deletions.
40 changes: 40 additions & 0 deletions src/database/keyvalue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -492,4 +492,44 @@ mod test {
fn test_sync_time() {
crate::database::test::test_sync_time(get_tree());
}

#[test]
fn test_iter_raw_txs() {
crate::database::test::test_iter_raw_txs(get_tree());
}

#[test]
fn test_del_path_from_script_pubkey() {
crate::database::test::test_del_path_from_script_pubkey(get_tree());
}

#[test]
fn test_iter_script_pubkeys() {
crate::database::test::test_iter_script_pubkeys(get_tree());
}

#[test]
fn test_del_utxo() {
crate::database::test::test_del_utxo(get_tree());
}

#[test]
fn test_del_raw_tx() {
crate::database::test::test_del_raw_tx(get_tree());
}

#[test]
fn test_del_tx() {
crate::database::test::test_del_tx(get_tree());
}

#[test]
fn test_del_last_index() {
crate::database::test::test_del_last_index(get_tree());
}

#[test]
fn test_check_descriptor_checksum() {
crate::database::test::test_check_descriptor_checksum(get_tree());
}
}
40 changes: 40 additions & 0 deletions src/database/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -647,4 +647,44 @@ mod test {
fn test_sync_time() {
crate::database::test::test_sync_time(get_tree());
}

#[test]
fn test_iter_raw_txs() {
crate::database::test::test_iter_raw_txs(get_tree());
}

#[test]
fn test_del_path_from_script_pubkey() {
crate::database::test::test_del_path_from_script_pubkey(get_tree());
}

#[test]
fn test_iter_script_pubkeys() {
crate::database::test::test_iter_script_pubkeys(get_tree());
}

#[test]
fn test_del_utxo() {
crate::database::test::test_del_utxo(get_tree());
}

#[test]
fn test_del_raw_tx() {
crate::database::test::test_del_raw_tx(get_tree());
}

#[test]
fn test_del_tx() {
crate::database::test::test_del_tx(get_tree());
}

#[test]
fn test_del_last_index() {
crate::database::test::test_del_last_index(get_tree());
}

#[test]
fn test_check_descriptor_checksum() {
crate::database::test::test_check_descriptor_checksum(get_tree());
}
}
Loading

0 comments on commit 0a7a1f4

Please sign in to comment.