-
Notifications
You must be signed in to change notification settings - Fork 307
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #1453: refactor(electrum) put the tx cache in electrum
2d2656a feat(electrum): re-export `transaction_broadcast` method (志宇) 53fa350 refactor(electrum)!: put the tx cache in electrum (LLFourn) Pull request description: Previously there was a `TxCache` that you passed in as part of the sync request. There are lots of downsides to this: 1. If the user forgets to do this you cache nothing 2. where are you meant to keep this cache? The example shows it being recreated every time which seems very suboptimal. 3. More API and documentation surface area. Instead just do a plain old simple cache inside the electrum client. This way at least you only download transactions once. You can pre-populate the cache with a method also and I did this in the examples. * [x] This pull request breaks the existing API ACKs for top commit: evanlinjin: self-ACK 2d2656a notmandatory: ACK 2d2656a Tree-SHA512: 6c29fd4f99ea5bd66234d5cdaf4b157a192ddd3baacc91076e402d8df0de7010bc482e24895e85fcb2f805ec6d1ce6cdb7654f8f552c90ba75ed35f80a00b856
- Loading branch information
Showing
8 changed files
with
308 additions
and
352 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.