Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(chain): Rename direct_conflicts_of_tx to direct_conflitcs #1164

Merged
merged 2 commits into from
Oct 10, 2023
Merged

ref(chain): Rename direct_conflicts_of_tx to direct_conflitcs #1164

merged 2 commits into from
Oct 10, 2023

Conversation

danielabrozzoni
Copy link
Member

Fixes #1138

Changelog notice

  • rename TxGraph::direct_conflicts_of_tx to TxGraph::direct_conflicts

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@danielabrozzoni danielabrozzoni self-assigned this Oct 10, 2023
@danielabrozzoni danielabrozzoni added this to the 1.0.0-alpha.2 milestone Oct 10, 2023
evanlinjin
evanlinjin approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d5c87c4

@danielabrozzoni danielabrozzoni merged commit 6ebdd19 into bitcoindevkit:master Oct 10, 2023
12 checks passed
@notmandatory notmandatory mentioned this pull request Oct 11, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels
None yet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.

TxGraph::direct_conflicts_of_tx should just be called direct_conflicts
2 participants
@danielabrozzoni @evanlinjin