-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bdk version to 1.0.0-alpha.3 #1255
Bump bdk version to 1.0.0-alpha.3 #1255
Conversation
1c9254d
to
66b2175
Compare
Before we release alpha.3, I think it's important we include this commit: We have changed the wallet API to initialize and load as separate methods. However, the method to initialize a wallet will wipe the database (without the aforementioned commit). |
@evanlinjin I agree that it's an important change to include, can you link a PR containing that commit? (Preferably, containing only that commit, so we can review quickly) |
I agree, please make a PR for this commit and I'll add it to the alpha.3 release. |
Doing it soon! |
@evanlinjin I created #1256 for ya. Please ACK and merge or I'll merge it. |
66b2175
to
4c490ba
Compare
Bump bdk_chain to 0.7.0 Bump bdk_bitcoin_rpc to 0.2.0 Bump bdk_electrum to 0.5.0
4c490ba
to
0032711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 0032711
Description
Notes to the reviewers
Changelog notice
See #1254
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing