Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typos): existant -> existent #1258

Merged
merged 1 commit into from
Jan 6, 2024
Merged

fix(typos): existant -> existent #1258

merged 1 commit into from
Jan 6, 2024

Conversation

storopoli
Copy link
Contributor

Description

These typos are blocking the Nix typo CI in #1257

Notes to the reviewers

Blocking #1257

Changelog notice

  • fix: typos in documentation

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@storopoli
fix(typos): existant -> existent
028caa9 
These typos are blocking the Nix typo CI in bitcoindevkit#1257
notmandatory
notmandatory approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 028caa9

Getting this merged will also tell CI it's OK to run your CI jobs!

@notmandatory notmandatory added the documentation Improvements or additions to documentation label Jan 6, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha.3 milestone Jan 6, 2024
@notmandatory notmandatory merged commit f6418ba into bitcoindevkit:master Jan 6, 2024
12 checks passed
@storopoli storopoli deleted the storopoli/typos branch January 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@storopoli storopoli

Labels
documentation Improvements or additions to documentation
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
2 participants
@storopoli @notmandatory