-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Pin clippy to rust 1.78.0 #1430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK de2763a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK de2763a
In rust-bitcoin we have started pinning our nightly compiler (which is where we run clippy) and we have a cronjob that runs every so often (was daily, but we reduced it to twice a week, and realistically it'd be fine if it were twice a year) which opens a PR to bump the pin. If the PR passes CI we know that we can accept it and increase our pin. If it fails CI then we can see that there's an upcoming lint failure and we can address it at our own pace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK de2763a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK de2763a
@apoelstra thanks for sharing! Definitely something we should do in the future, we did forget to bump the pin on CI a few times. Opened a new good first issue: #1433 |
This PR pins clippy check in CI to the rust 1.78 toolchain, which prevents new lints in stable releases from interrupting the usual workflow. Because rust versions are released on a predictable schedule, we can revisit this setting in the future as needed (say 3-6 months).
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing