Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update CONTRIBUTING.md #1584

Merged
merged 1 commit into from
Sep 5, 2024
Merged

docs: update CONTRIBUTING.md #1584

merged 1 commit into from
Sep 5, 2024

Conversation

ValuedMammal
Copy link
Contributor

Update CONTRIBUTING.md

  • Made small corrections and added some things that were missing. If there's something else you think should be included let me know.

closes #1394

Changelog notice

Checklists

All Submissions:

@notmandatory notmandatory added the documentation Improvements or additions to documentation label Aug 30, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Aug 30, 2024
notmandatory
notmandatory approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6b881f8

@LagginTimes
Copy link
Contributor

ACK 6b881f8

storopoli
storopoli approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6b881f8

oleonardolima
oleonardolima approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6b881f8

@notmandatory notmandatory merged commit 257c5f7 into bitcoindevkit:master Sep 5, 2024
21 checks passed
@ValuedMammal ValuedMammal deleted the doc/contributing branch September 5, 2024 20:04
This was referenced Sep 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@oleonardolima oleonardolima oleonardolima approved these changes

@storopoli storopoli storopoli approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels
documentation Improvements or additions to documentation
Projects
BDK
Archived in project
Milestone
1.0.0-beta
Development

Successfully merging this pull request may close these issues.

Have more code conventions and guidelines
5 participants
@ValuedMammal @LagginTimes @notmandatory @oleonardolima @storopoli