refactor(wallet): use Amount everywhere
#1595
Merged
+41
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
35
to
39
| impl IsDust for u64 { | ||
| fn is_dust(&self, script: &Script) -> bool { | ||
| *self < script.minimal_non_dust().to_sat() | ||
| Amount::from_sat(*self).is_dust(script) | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: I guess this could be moved to coin_selection, it's the only place still using is_dust with a u64, right ?
notmandatory
reviewed
Sep 9, 2024
| let mut tx_builder = wallet.build_tx(); | ||
| tx_builder | ||
| .add_recipient(faucet_address.script_pubkey(), SEND_AMOUNT) | ||
| .add_recipient(address.script_pubkey(), SEND_AMOUNT) |
There was a problem hiding this comment.
👍 thanks for cleaning this up!
This was referenced Sep 13, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #1426 that refactors wallet internals to use
bitcoin::Amount(nearly) everywhere. I chose not to change any public types incoin_selection.rsthat still useu64as that might require more discussion.partially addresses #1432
fixes #1434
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing