PoWChain WIP #1641
Closed
PoWChain WIP #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
commented
Oct 4, 2024
Comment on lines
+195
to
+203
| /// Apply the given `changeset`. | ||
| pub fn apply_changeset(&mut self, changeset: &ChangeSet) -> Result<(), MissingGenesisError> { | ||
| let old_tip = self.tip.clone(); | ||
| let new_tip = | ||
| apply_changeset_to_checkpoint(old_tip, changeset, self.difficulty_map.clone())?; | ||
| self.tip = new_tip; | ||
| debug_assert!(self._check_changeset_is_applied(changeset)); | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
I'm finding this quite hard to reason about and it seems rather dangerous. How do you envision it being used here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: