Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite - allow persisting anchor without tx #1736

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Sqlite - allow persisting anchor without tx #1736

merged 4 commits into from
Nov 28, 2024

Conversation

evanlinjin
Copy link
Member

@evanlinjin evanlinjin commented Nov 20, 2024 •
edited by ValuedMammal
Loading

Description

Previously, we may error when we insert an anchor where the txid being anchored has no corresponding tx.

closes #1712
replaces #961

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@evanlinjin
Copy link
Member Author

@ValuedMammal feel free to take this one over. I'm assuming this will fix the problem, but needs tests.

@notmandatory
Copy link
Member

Tests from #961 could be useful.

@notmandatory notmandatory added module-database audit Suggested as result of external code audit labels Nov 21, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 21, 2024
@notmandatory notmandatory mentioned this pull request Nov 22, 2024
Closed
@ValuedMammal ValuedMammal force-pushed the fix/sqlite-insert-anchor-before-tx branch from 0aa1f24 to 4a71cf4 Compare November 25, 2024 01:57
@ValuedMammal ValuedMammal marked this pull request as ready for review November 25, 2024 02:05
@evanlinjin evanlinjin force-pushed the fix/sqlite-insert-anchor-before-tx branch from 4a71cf4 to 18f5f3f Compare November 25, 2024 23:30
@evanlinjin
Copy link
Member Author

@ValuedMammal I forced pushed to rebase on master.

evanlinjin
evanlinjin commented Nov 25, 2024
View reviewed changes
Copy link
Member Author

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 18f5f3f

ValuedMammal
ValuedMammal approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 18f5f3f

@evanlinjin evanlinjin merged commit bf42562 into bitcoindevkit:master Nov 28, 2024
21 checks passed
@nymius nymius mentioned this pull request Nov 29, 2024
Closed
@oleonardolima oleonardolima mentioned this pull request Dec 3, 2024
Open
6 tasks
@notmandatory notmandatory mentioned this pull request Dec 11, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

Assignees

@evanlinjin evanlinjin

Labels
audit Suggested as result of external code audit module-database
Projects
BDK
Archived in project
Milestone
1.0.0-beta
Development

Successfully merging this pull request may close these issues.

Sqlite: check anchor to tx foreign key constraint
3 participants
@evanlinjin @notmandatory @ValuedMammal