Add a flag to fill-in PSBT_GLOBAL_XPUB, expose --offline_signers in the CLI
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also needs the CHANGELOG update |
|
Maybe we can merge this one first to master and then either rebase |
afilini
added a commit
to afilini/bdk
that referenced
this pull request
Dec 1, 2020
Log the changes made in PR bitcoindevkit#200
afilini
force-pushed
the
feat/offline-signers-cli
branch
from
6b75539
to
5232a71
Compare
afilini
added a commit
to afilini/bdk
that referenced
this pull request
Dec 1, 2020
Log the changes made in PR bitcoindevkit#200
afilini
force-pushed
the
feat/offline-signers-cli
branch
from
5232a71
to
004a58d
Compare
|
Should be ready for review. There's an interesting discussion about the correct behavior in issue #199. The implementation should match what was said in that discussion. |
afilini
added a commit
to afilini/bdk
that referenced
this pull request
Dec 1, 2020
Log the changes made in PR bitcoindevkit#200
afilini
force-pushed
the
feat/offline-signers-cli
branch
from
004a58d
to
31ddb7e
Compare
The `--offline_signer` flag forces the addition of `non_witness_utxo` and the full witness and redeem script for every output, which makes it easier for the signer to identify the change output. Closes bitcoindevkit#199
afilini
added a commit
to afilini/bdk
that referenced
this pull request
Dec 1, 2020
Log the changes made in PR bitcoindevkit#200
afilini
force-pushed
the
feat/offline-signers-cli
branch
from
31ddb7e
to
7f36dd2
Compare
|
Rebase on |
RCasatta
reviewed
Dec 1, 2020
afilini
force-pushed
the
feat/offline-signers-cli
branch
from
7f36dd2
to
6b5c3bc
Compare
|
utACK 6b5c3bc |
|
utACK |
nickfarrow
pushed a commit
to nickfarrow/bdk
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still in draft since I have to write tests for
TxBuilder::add_global_xpubs()