Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI, bump MSRV to 1.56.1 #638

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix CI, bump MSRV to 1.56.1 #638

merged 1 commit into from
Jun 27, 2022

Conversation

danielabrozzoni
Copy link
Member

@danielabrozzoni danielabrozzoni commented Jun 21, 2022 •
edited
Loading

Description

This PR fixes the CI, which is currently failing after a Github Actions update.
The MSRV is bumped to 1.56.1 (from 1.56.0), since that's reqwest's current MSRV.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@danielabrozzoni danielabrozzoni marked this pull request as ready for review June 22, 2022 07:31
@danielabrozzoni danielabrozzoni changed the title Fix CI Update CI, bump MSRV to 1.56.1 Jun 22, 2022
@danielabrozzoni danielabrozzoni changed the title Update CI, bump MSRV to 1.56.1 Fix CI, bump MSRV to 1.56.1 Jun 22, 2022
@danielabrozzoni danielabrozzoni self-assigned this Jun 23, 2022
@danielabrozzoni danielabrozzoni mentioned this pull request Jun 24, 2022
Merged
3 tasks
@danielabrozzoni
Bump MSRV from 1.56.0 to 1.56.1
b289c4e 
In this way we can continue using reqwest v0.11, whose MSRV is now
1.56.1
The only difference between v1.56.0 and v1.56.1 is a bug fix for
CVE-2021-42574.
afilini
afilini approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b289c4e

@afilini afilini merged commit 5c566bb into bitcoindevkit:master Jun 27, 2022
@danielabrozzoni danielabrozzoni mentioned this pull request Jun 28, 2022
Merged
6 tasks
@danielabrozzoni danielabrozzoni deleted the fix_ci branch August 16, 2022 17:06
@danielabrozzoni danielabrozzoni restored the fix_ci branch August 16, 2022 17:06
@danielabrozzoni danielabrozzoni deleted the fix_ci branch August 16, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afilini afilini afilini approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels
None yet
Projects
BDK Maintenance
Archived in project
Milestone
Release 0.20.0 Feature Freeze
Development

Successfully merging this pull request may close these issues.
2 participants
@danielabrozzoni @afilini