-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow signing only specific leaf hashes #645
Allow signing only specific leaf hashes #645
Conversation
8ca6f19
to
5137186
Compare
d214801
to
b8459a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK, but I would also add a way to disable signing for the internal key (which is required if you want to force the use of a a script-spend path)
e6ba47c
to
7e1a87a
Compare
Done :) |
7e1a87a
to
0e91cbf
Compare
Rebased |
We would previously always try to sign with the taproot internal key, and try to sign all the script leaves hashes. Instead, add the `sign_with_tap_internal_key` and `TapLeaveOptions` parameters, to be able to specify if we should sign with the internal key, and exactly which leaves we should sign. Fixes bitcoindevkit#616
0e91cbf
to
a713a5a
Compare
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK a713a5a
Fixes #616
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md