Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wallet sync for RpcBlockchain #683

Merged
merged 3 commits into from
Aug 4, 2022

Commits on Aug 4, 2022

  1. New RpcBlockchain implementation with various fixes

    The new implementation fixes the following:
    * We can track more than 100 scriptPubKeys
    * We can obtain more than 1000 transactions per sync
    * `TransactionDetails` for already-synced transactions are updated when
      new scriptPubKeys are introduced (fixing the missing balance/coins
          issue of supposedly tracked scriptPubKeys)
    
    `RpcConfig` changes:
    * Introduce `RpcSyncParams`.
    * Remove `RpcConfig::skip_blocks` (this is replaced by
      `RpcSyncParams::start_time`).
    evanlinjin committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    ac19c19 View commit details
    Browse the repository at this point in the history
  2. Rpc: Manually add immature coinbase utxos

    Before this commit, the rpc backend would not notice immature utxos
    (`listunspent` does not return them), making the rpc balance different
    to other blockchain implementations.
    
    Co-authored-by: Daniela Brozzoni <danielabrozzoni@protonmail.com>
    evanlinjin and danielabrozzoni committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    5eb74af View commit details
    Browse the repository at this point in the history
  3. Various RpcBlockchain improvements

    These are as suggested by @danielabrozzoni and @afilini
    
    Also introduced `RpcSyncParams::force_start_time` for users who
    prioritise reliability above all else.
    
    Also improved logging.
    evanlinjin committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    5eeba6c View commit details
    Browse the repository at this point in the history