Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bip39 crate to v2.0.0 #875

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Bump bip39 crate to v2.0.0 #875

merged 1 commit into from
Mar 26, 2023

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Feb 28, 2023 •
edited
Loading

Description

The updated version of rust-bip39 was just released. It also bumped the pinned version of unicode-normalization, which previously had lead to some incompatibilities.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@tnull
Copy link
Contributor Author

tnull commented Feb 28, 2023

Not sure if #561 is addressed with this for the time being.

@tnull
Copy link
Contributor Author

tnull commented Feb 28, 2023

CI is failing due to an unrelated MSRV violation: "error: package base64ct v1.6.0 cannot be built because it requires rustc 1.60 or newer, while the currently active rustc version is 1.57.0"

We had already seen this issue in LDK (cf. lightningdevkit/rust-lightning#2055), I now opened an issue towards electrsd: RCasatta/electrsd#56

@notmandatory notmandatory mentioned this pull request Feb 28, 2023
Closed
21 tasks
@notmandatory
Copy link
Member

The CI issue if fixed in the release/0.27 branch, please rebase this PR to be merged to that branch. We're going to use release/0.27 for maintenance fixes while the new 1.0.0 stuff is being merged to master, starting with #793.

@tnull
Copy link
Contributor Author

tnull commented Mar 7, 2023

Rebased on release/0.27.

@notmandatory notmandatory changed the base branch from master to release/0.27 March 8, 2023 04:00
rajarshimaitra
rajarshimaitra approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK a4647cf

notmandatory
notmandatory approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK a4647cf

Verified creating and restoring wallet from mnemonic manually with bdk-cli .

@notmandatory
Copy link
Member

I also did a quick test with bdk-ffi using this PR branch version of bdk and works fine.

CLASSPATH=./tests/jna/jna-5.8.0.jar cargo test --features uniffi/bindgen-tests,uniffi/cli

@notmandatory notmandatory mentioned this pull request Mar 16, 2023
Closed
8 tasks
@thunderbiscuit thunderbiscuit mentioned this pull request Mar 24, 2023
Closed
@notmandatory notmandatory added this to the 0.27.3 milestone Mar 26, 2023
@notmandatory notmandatory merged commit 10608af into bitcoindevkit:release/0.27 Mar 26, 2023
@notmandatory
Copy link
Member

Note, this was already bumped to 2.0.0 in the master branch so we don't need a corresponding PR there.

@notmandatory notmandatory mentioned this pull request Apr 11, 2023
Closed
11 tasks
@tnull tnull mentioned this pull request Jan 7, 2024
Merged
notmandatory added a commit that referenced this pull request Jan 7, 2024
@notmandatory
Merge #1259: Bump bip39 dependency to v2.0
1ff9d5c 
8694624 Bump `bip39` to v2.0 (Elias Rohrer)

Pull request description:

  We previously bumped the `bip39` version to 2.0 [in the 0.2X release branch](#875). Back then, bumping it in `master` was [assumed unnecessary](#875 (comment)). It seems this was erroneous, as the current `1.0.1` dependency is present since #793, which was merged before the bump in `release/0.27`.

  Here, we therefore bump the crate version in `master` after all.

ACKs for top commit:
  notmandatory:
    ACK 8694624

Tree-SHA512: a109219bc97bb8e965e8b10e72439aa898b710d1d1a154801ce499ad47475a6b23448d85e0de3f306f990573d1fccdae7d587ed41676a01f91d66a719782eae1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@rajarshimaitra rajarshimaitra rajarshimaitra approved these changes

Assignees

@tnull tnull

Labels
None yet
Projects
BDK Maintenance
Archived in project
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tnull @notmandatory @rajarshimaitra