-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify reveal_to_target
logic
#890
Simplify reveal_to_target
logic
#890
Conversation
fdca1aa
to
0caad68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one. This version of the code is easy to follow. I just have a nit.
); | ||
|
||
// if we need to reveal new indexes, the latest revealed index goes here | ||
let mut reveal_to_index = None; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should call this latest_reveal_index
. It might remove the need to have a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably need a comment anyway to inform that this variable is to be mutated "if we need to reveal new indices".
- Remove unnecessary check - Better comments - Better variable names - Add test for scanning txouts with lookahead
0caad68
to
72b1e2a
Compare
Description
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: