-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation regarding absolute_fee and fee_rate updated #957
Documentation regarding absolute_fee and fee_rate updated #957
Conversation
crates/bdk/src/wallet/tx_builder.rs
Outdated
@@ -190,6 +190,9 @@ impl<'a, D, Cs: CoinSelectionAlgorithm, Ctx: TxBuilderContext> TxBuilder<'a, D, | |||
} | |||
|
|||
/// Set an absolute fee | |||
/// The fee_absolute method refers to the absolute transaction fee in satoshis (sats). | |||
/// If anyone set both the fee_absolute method and the fee_rate method, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar nit:
/// If anyone set both the fee_absolute method and the fee_rate method, | |
/// If anyone sets both the fee_absolute method and the fee_rate method, |
While we are updating the absolute fee documentation, perhaps we should also update the fee rate documentation for the fee_rate method directly above the fee_absolute method. Is the fee rate in satoshi/vbyte (e.g., 5.0 satoshi/vbyte)? |
I've updated the documentation for the fee_rate method in this pull request: #969 |
Hi, can you please squash your commits together? Then I will merge this :) |
I've squashed all of the commits together here: #969 |
8a5404b
to
17b3d65
Compare
Hello, I have squashed my commits. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 17b3d65
Hey, can you please rebase on master to pick up the CI fixes? |
17b3d65
to
83f100c
Compare
I rebased the branch. Thank you |
I need your commits to be signed for merging: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
Update tx_builder.rs
83f100c
to
10b4b6c
Compare
I signed the commits. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 10b4b6c
Thank You |
Description
This pr solves this issue #856
Updated the documentation for absolute fee and fee rate in BDK docs
All Submissions:
Bugfixes: