Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup IndexedTxGraph test. #959

Merged
merged 1 commit into from
May 1, 2023

Conversation

rajarshimaitra
Copy link
Contributor

@rajarshimaitra rajarshimaitra commented Apr 29, 2023

Description

This is a follow-up after #926 to clean up the test code. It should be straight forward to review.

  • Add explainer doc for the test.
  • Simplify test code.
  • Add one more edge case for coinbase maturity test.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

- Explainer doc added for the test.
- Test code simplified.
- One more edge cases added.
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 29055658a643f72923882785fbd9894ba38b27cf

@evanlinjin evanlinjin merged commit 702fe7a into bitcoindevkit:master May 1, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.1 milestone Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants