Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using BDK with Tor #134

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

rorp
Copy link
Contributor

@rorp rorp commented Dec 17, 2022

Added Tor tutorial

See bitcoindevkit/bdk#66

@netlify
Copy link

netlify bot commented Dec 17, 2022

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit a71548c
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/64ec98d78c988c0008f073c8
😎 Deploy Preview https://deploy-preview-134--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rorp rorp mentioned this pull request Dec 17, 2022
8 tasks
@notmandatory
Copy link
Member

notmandatory commented Jan 1, 2023

Thanks for this, a few suggestions:

  1. In the first section after explaining how to install tor you should probably also add that it needs to be started in another shell with:
     % tor
    And then need to wait for the boot strapping to finish.
  2. Some of your code examples need the code indents fixed.
  3. You need to sign your commit.
  4. You may want to remove the compact block filters example since it takes so long to sync, or at least start with something quicker like electrum, and then show it with cbf.
  5. Since this is a tutorial you should probably move it to the tutorial part of the website

@notmandatory
Copy link
Member

I've confirmed the CBF, electrum and both esplora sync parts work. But I did have to run the electrum and one of the esplora examples twice after seeing timeouts, most likely tor network related. So probably should mention that if the reader sees a timeout they should try rerunning it.

I was unable to get the libtor example to build, I'm on an M1 mac and that crate may need to be updated to work with an aarch64 system.

@rorp
Copy link
Contributor Author

rorp commented Jan 3, 2023

I was unable to get the libtor example to build, I'm on an M1 mac and that crate may need to be updated to work with an aarch64 system.

libtor builds Tor from the sources, it's 100% compatible with aarch64 systems. Most likely you don't have autotools and/or libtool installed. I need to update the article with the build instructions.

@notmandatory
Copy link
Member

I was unable to get the libtor example to build, I'm on an M1 mac and that crate may need to be updated to work with an aarch64 system.

libtor builds Tor from the sources, it's 100% compatible with aarch64 systems. Most likely you don't have autotools and/or libtool installed. I need to update the article with the build instructions.

I fixed my build problem, I had to set these env variables, now builds fine:

export LDFLAGS="-L/opt/homebrew/opt/openssl@3/lib"
export CPPFLAGS="-I/opt/homebrew/opt/openssl@3/include"

@notmandatory
Copy link
Member

You'll also need to update the config.js file to add your tutorial to the sidebar list.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 35a6e64

All example code works for me, thanks for the updates. We will need to hold off on merging until bitcoindevkit/bdk#816 goes in so the link to the example code is available.

@thunderbiscuit
Copy link
Member

Is this ready to go in? @rorp @notmandatory let's get it in if we can and the content is still relevant.

@notmandatory
Copy link
Member

@thunderbiscuit sorry for the slow response, yes let's merge this. It's great info and will be something we want to incorporate into a future user bdk user guide.

@thunderbiscuit thunderbiscuit merged commit a71548c into bitcoindevkit:master Aug 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants