Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bdk-cli default features install #92

Merged

Conversation

thunderbiscuit
Copy link
Member

Fixes #30.

@netlify
Copy link

netlify bot commented Mar 17, 2022

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit b889ded
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/624cfef3ecac5a0008b1f827
😎 Deploy Preview https://deploy-preview-92--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7773339

With one nit.

docs/_blog/spending_policy_demo.md Outdated Show resolved Hide resolved
@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Apr 5, 2022

@rajarshimaitra @notmandatory now ready to go. The line doesn't have any features at all, which the blog post does not require.

cargo install bdk-cli

Edit: This comment is no longer true, the line is cargo install bdk-cli --features electrum.

Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReACK b889ded

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b889ded

@notmandatory notmandatory merged commit d137055 into bitcoindevkit:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove the unnecessary --features electrum,repl in the cli instructions
3 participants