-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Currently we are converting error types to strings, this makes the library worse when used with standard error handling crates by downstream users. Instead we can put each error type inside the respective error variant and implement `std::error::Error` so that `source` can be called by error handling libraries for better error output. Please note this removes `PartialEq` and `Eq` from the error type which makes it harder to use. This is an ecosystem-wide problem caused by the `io::Error`, there is currently (to the best of my knowledge) no good solution other than removing the derives. This is an API breaking change.
- Loading branch information
Showing
1 changed file
with
50 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters