Upgrade bitcoin and miniscript #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
06-11-upgrade-bitcoin
branch
3 times, most recently
from
4aadc82
to
44a10eb
Compare
|
|
|
This PR would be nicer if we implemented the suggestion in #80 |
|
Thanks for your contribution! The rest LGTM |
|
Leave it with me. |
|
If #84 is acceptable it could go in before this one and that would fix the CI fails. |
|
I'll put this on ice until my other PRs get merged/closed. |
tcharding
force-pushed
the
06-11-upgrade-bitcoin
branch
6 times, most recently
from
11dc1e1
to
8a9eea7
Compare
Upgrade to `miniscript` v0.10.0 and `bitcoin` v0.30.0 API Changes: - `Network` is now `non_exhaustive` so we implement `TryFrom` instead of `From`. - `get_client`: Now takes an `HWIChain` instead of a generic, this is less general, and less usable. Done because `From<Network>` can no longer be implemented on `HWIChain` because of the newly added `non_exhaustive` on `Network`. - `Address` now has a tag and can only be deserialized unchecked. We just call `assume_checked` in the unit tests. Is the error handling for new `TryFrom` acceptable to the project?
We currently use `base64` to deserialize a vector. At the same time we use `base64` indirectly from `rust-bitcoin` when deserializing a PSBT. If we remove the dependency on `base64` and use the re-export from bitcoin it saves having to keep the dependency and transient dependency in sync so we don't get multiple versions of the same crate in the dependency tree.
tcharding
force-pushed
the
06-11-upgrade-bitcoin
branch
from
8a9eea7
to
f720747
Compare
|
Changes in force push
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR to this project.
base64dependency in favour ofbitcoin::base64Note please, this makes the following API changes:
Networkis nownon_exhaustiveso we implementTryFrominstead ofFrom. Also add panic inIntoPy, we already unwrap so it seems ok, please note.get_client: Now takes anHWIChaininstead of a generic, this is less general, and less usable. Done becauseFrom<Network>can no longer be implemented onHWIChainbecause of the newly addednon_exhaustiveonNetwork(added a test constTESTNETforHWIChain(Network::Testnet))Addressnow has a tag and can only be deserialized unchecked. We just callassume_checkedin the unit tests.Is the error handling for new
TryFromacceptable to the project?