Use bitcoin::Network
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
06-20-hwi-chain
branch
from
f0c5c58
to
db857d6
Compare
|
hmmm, not sure why MSRV job is failing - this PR does not touch anything that effects the dependencies that make MSRV build? Any suggestions please? |
|
If #84 is acceptable it could go in before this one and that would fix the CI fails. |
tcharding
force-pushed
the
06-20-hwi-chain
branch
from
db857d6
to
325b3ff
Compare
The `HWIChain` type is only required so we can get around the orphan rule and implement `IntoPy`. We can use a wrapper type (wrapping `bitcoin::Network`) to achieve this and the use plain old `Network` everywhere else. This simplifies the code and makes it more clear to the casual reader who is familiar already with `rust-bitcoin`.
tcharding
force-pushed
the
06-20-hwi-chain
branch
from
325b3ff
to
62c2929
Compare
danielabrozzoni
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HWIChaintype is only required so we can get around the orphan rule and implementIntoPy. We can use a wrapper type (wrappingbitcoin::Network) to achive this and the use plain oldNetworkeverywhere else. This simplifies the code and makes it more clear to the casual reader who is familiar already withrust-bitcoin.Fix: #80