Remove "use-miniscript" feature #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `use-miniscript` feature just enables the optional `miniscript` dependency, this is redundant because one can enable the dependency with `cargo check --features=miniscript`. Also the feature gating works just fine with `#[cfg(feature = "miniscript")]`
tcharding
changed the title
danielabrozzoni
approved these changes
Jun 28, 2023
|
Happy to be able to share, I learned so much the last years working with the rust-bitcoin crew, good to disseminate the knowledge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
use-miniscriptfeature just enables the optionalminiscriptdependency, this is redundant because one can enable the dependency withcargo check --features=miniscript.Also the feature gating works just fine with
#[cfg(feature = "miniscript")]