Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bitcoin #91

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Upgrade bitcoin #91

merged 1 commit into from
Feb 5, 2024

Conversation

tcharding
Copy link
Contributor

@tcharding tcharding commented Oct 16, 2023 •
edited
Loading

Upgrade

  • bitcoin to v0.31.0
  • miniscript v11.0.0

@tcharding tcharding force-pushed the 10-16-upgrade-bitcoin branch 3 times, most recently from ee3c01a to b956c38 Compare October 16, 2023 06:40
@tcharding tcharding marked this pull request as ready for review November 23, 2023 02:21
@tcharding
Copy link
Contributor Author

I think the CI fail is unrelated to this PR, am I wrong?

@danielabrozzoni
Copy link
Member

I think the CI fail is unrelated to this PR, am I wrong?

Yep, I'll try to look into it these days, thanks!

@tcharding
Copy link
Contributor Author

No changes, just seeing if CI is working.

@danielabrozzoni
Copy link
Member

Thanks! Can you try rebasing on master? CI should be fixed now :)

@tcharding
Upgrade miniscript/bitcoin dependency
943b6c1 
Upgrade:

- bitcoin to v0.31.0
- miniscript to v11.0.0
@tcharding
Copy link
Contributor Author

Rebase only, no other changes.

@getong getong mentioned this pull request Jan 27, 2024
Closed
5 tasks
danielabrozzoni
danielabrozzoni approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long,

ACK 943b6c1

@danielabrozzoni danielabrozzoni merged commit f3058b7 into bitcoindevkit:master Feb 5, 2024
7 checks passed
@tcharding
Copy link
Contributor Author

No worries, glad we got there! Thanks

@tcharding tcharding deleted the 10-16-upgrade-bitcoin branch February 7, 2024 03:50
@notmandatory notmandatory mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielabrozzoni danielabrozzoni danielabrozzoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcharding @danielabrozzoni