Silent payments v1 #1848
Open
Silent payments v1 #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
reviewed
Nov 29, 2022
| address: string, | ||
| value: number, | ||
| ): Promise<void> { | ||
| await regtestUtils.broadcast(tx.toBuffer().toString('hex')); |
junderw
reviewed
Nov 29, 2022
| senderKeyPair.privateKey!, | ||
| ); | ||
|
|
||
| const receiverSharedSecred = ecc.pointMultiply( |
There was a problem hiding this comment.
nit: receiverSharedSecret (t at the end)
junderw
reviewed
Nov 29, 2022
| }); | ||
|
|
||
| // destination | ||
| const { address } = bitcoin.payments.p2tr({ |
There was a problem hiding this comment.
A little more explanation would be nice here.
junderw
reviewed
Nov 29, 2022
| sharedSecret: Buffer, | ||
| ): { psbt: bitcoin.Psbt; address: string } { | ||
| const psbt = new bitcoin.Psbt({ network: regtest }); | ||
| psbt.addInput({ |
There was a problem hiding this comment.
A little more explanation would be nice here.
junderw
reviewed
Nov 29, 2022
|
|
||
| const ECPair = ECPairFactory(ecc); | ||
|
|
||
| // This logic will be extracted to ecpair |
junderw
requested changes
Nov 29, 2022
There was a problem hiding this comment.
Needs a little more explanation for people who haven't read the gist and just happen to read this file.
Maybe make some diagrams or something in a large block comment.
As long as someone can read it and understand what a silent payment is, why its useful, and in which parts of the code are we doing something special to allow it to happen.
(also pointing out how taproot support helps us to perform this would be helpful for those learning)
RaySwag522
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silent Payments
More on
Silent Payments:silent-payments.speccontains a simple test for Silent Payments.The purpose of this PR is:
p2tr-v1branch gets merged)Silent Paymentsshould be constructed and check that this implementation is correctThis PR is not concerned on the scanning/detecting silent payments.