Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletters: add 224 (2022-11-02) #909

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

harding
Copy link
Collaborator

@harding harding commented Oct 29, 2022

- *More permissive policies require widespread acceptance or better peering:*
A Bitcoin Core node makes eight outbound connections by default,
so at least 30% of the network needs to support a more
permissive policy before a node has 95% chance of finding at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
permissive policy before a node has 95% chance of finding at
permissive policy before a node has a 95% chance of finding at

their capabilities using the services field of the P2P `addr`,
[`addrv2`][topic addr v2], and `version` messages, allowing nodes
with common interests to find each other and form sub-networks
(called *preferential peering*). Alternatively full node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(called *preferential peering*). Alternatively full node
(called *preferential peering*). Alternatively, full node

Comment on lines 66 to 77
easier to identify and censor. It also requires miners to be
join these sub-networks and alternative networks, raising the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
easier to identify and censor. It also requires miners to be
join these sub-networks and alternative networks, raising the
easier to identify and censor. It also requires miners to
join these sub-networks and alternative networks, raising the

@harding harding marked this pull request as ready for review November 1, 2022 05:59
@renepickhardt
Copy link

renepickhardt commented Nov 1, 2022

I guess you may wish to cover https://twitter.com/brqgoo/status/1587397646125260802?t=ihdFNLORbmxCa-6NyFUFMQ&s=19 as a crucial and exploited bug in this weeks newsletter? (lnd nodes seem to be affected and their funds may be at risk because they don't sync with the chain anymore)

Edit:
Seems like AJ has notifed the LL team about two weeks ago: https://twitter.com/ajtowns/status/1587414992961216512?t=nf8d4DfunJL-lo4f4HM6SQ&s=19

Edit2:
There is an lnd patch avsilable that includes a newer version of btcd lightningnetwork/lnd#7098. The update to btcd was provided at btcsuite/btcd@acb7313

identify which hop the payment failed at by comparing how many
satoshis it sent to how many satoshis it received back.

- **Anchor outputs workaround:** Bastian Teinturier [posted][teinturier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Anchor outputs workaround:** Bastian Teinturier [posted][teinturier
- **Anchor outputs workaround:** Bastien Teinturier [posted][teinturier

any transactions which [reuse an address][topic output linking].

- *More permissive policies require widespread acceptance or better peering:*
A Bitcoin Core node makes eight outbound connections by default,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is me being annoying and saying "well, ackshually..."

Suggested change
A Bitcoin Core node makes eight outbound connections by default,
A Bitcoin Core node relays transactions with eight peers via outbound connections by default,

@glozow
Copy link
Collaborator

glozow commented Nov 1, 2022

I guess you may wish to cover https://twitter.com/brqgoo/status/1587397646125260802?t=ihdFNLORbmxCa-6NyFUFMQ&s=19 as a crucial and exploited bug in this weeks newsletter? (lnd nodes seem to be affected and their funds may be at risk because they don't sync with the chain anymore)

I imagine this would certainly be covered in next week's newsletter. Not to downplay the importance, but this is happening <24hr before publishing is scheduled and the newsletter usually covers things from the week before.

@renepickhardt
Copy link

I know that it was short notice but I decided to drop/suggest it here as I recall @harding once mentionig that for critical security upgrades the newsletter can have last minute hotfixes and updating lnd/btcd seems critical otherwise peers could steel funds.

@glozow
Copy link
Collaborator

glozow commented Nov 1, 2022

Ah wasn't aware, ignore me heh

ensure a new policy is good for everyone (or as nearly as it can be),
and then enabled it as soon as it's implemented. Any options that
have been added have either been to control resource usage in ways
that don't significantly effect tx propagation, to allow people to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "affect", of course, but we can't fix it since it's a direct quotation. Either add a [sic] -- but that looks like you're picking on AJ -- or consider paraphrasing. Helpful discussion here: Quotations That Include Errors.

@LarryRuane
Copy link
Collaborator

Ah wasn't aware, ignore me heh

But, just to be clear, we should not ignore you when you say "ignore me" 😸

[lnd secpol]: https://github.com/lightningnetwork/lnd/security/policy
[news207 bc22558]: /en/newsletters/2022/07/06/#bitcoin-core-22558
[towns consistency]: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2022-October/021116.html
[news205 rbf]: /2022/06/22/#full-replace-by-fee
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[news205 rbf]: /2022/06/22/#full-replace-by-fee
[news205 rbf]: /en/newsletters/2022/06/22/#full-replace-by-fee


- **BIP324 message identifiers:** Pieter Wuille [posted][wuille bip324]
to the Bitcoin-Dev mailing list a response to the update of the
[BIP324][] draft specification for the [version 2 P2P encrypted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

satoshis it sent to how many satoshis it received back.

- **Anchor outputs workaround:** Bastian Teinturier [posted][teinturier
fees] to the Lightning-Dev a [proposal][bolts #1036] for replacing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fees] to the Lightning-Dev a [proposal][bolts #1036] for replacing
fees] to the Lightning-Dev mailing list a [proposal][bolts #1036] for replacing

- [Bitcoin Core #23927][] restricts `getblockfrompeer` on pruned nodes
to heights below the node's current synchronization progress. This
prevents a footgun arising from retrieving future blocks making the
node's block-files ineligible for pruning.</br>
Copy link
Contributor

@bitschmidty bitschmidty Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the <br /> (slash after) is intended or if two newlines were intended here.

pruning, and cause a pruned node to exceed its data allowance.

- [Bitcoin Core #25957][] improves the performance of rescans for
descriptor wallets by using the BIP157 block filter index (if enabled)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

Suggested change
descriptor wallets by using the BIP157 block filter index (if enabled)
descriptor wallets by using the [BIP157][topic compact block filters] block filter index (if enabled)

@harding
Copy link
Collaborator Author

harding commented Nov 2, 2022

FYI, our publication policy is here: https://gist.github.com/harding/0dffdde00761262ca094219c33b8ff22 (yeah, I should probably move that into the repo at some point). We'll add important security announcements at any time, e.g. we added this less than an hour before publication.

In cases like the previous LND vulnerability where I also didn't learn about it until the day before publication, we announce the availability of a security critical fix immediately and then go into details in the subsequent week's newsletter. I'm going to do the same for this week.

Thanks @renepickhardt for mentioning and everyone else for discussion!

@harding
Copy link
Collaborator Author

harding commented Nov 2, 2022

Edits made, thanks everyone! Also added lede, updated releases/RCs with LND info, and added topic links. Cheers!

@bitschmidty
Copy link
Contributor

ACK 8a50ac2 sans a couple topic description fixups

@bitschmidty bitschmidty merged commit 8518747 into bitcoinops:master Nov 2, 2022
@bitschmidty
Copy link
Contributor

Another great newsletter thanks @harding @glozow @xekyo for authoring and for @adamjonas @LarryRuane @glozow for reviewing! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants