fix narrowing warning for param definitions #1374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the Python bindings with Clang 11, the param definitions give many noisy warnings of the form:
It appears to be a limitation of Clang: It is worried about storing a value greater than
0xFF
in auint8_t
field.type
, but it does not recognize that the ternary expression branch will never be hit because of the(TYPE) <= 0xFF
check.It can be fixed by storing
TYPE & 0xFF
instead. This is a no-op, but since everything's a compile-time constant it shouldn't cause any change in the generated code.I guess few people are compiling the bindings with Clang, so I understand if you reject the PR because it adds complexity for a niche case.