Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Instances for :& - bug or feature? #290

Closed
m4dc4p opened this issue Sep 28, 2021 · 5 comments
Closed

Missing Instances for :& - bug or feature? #290

m4dc4p opened this issue Sep 28, 2021 · 5 comments

Comments

@m4dc4p
Copy link
Contributor

m4dc4p commented Sep 28, 2021

In writing some queries, I've found a need for ToAlias/ToAliasReference/SqlSelect instances for the :& type. There are already instances of those classes for (,), (,,), and so on, and :& doesn't really seem any different.

Is this an oversight or is there some reason those instances aren't defined for :&?

Thanks!

(I'm using 3.4.2.1 so please let me know if I just need to upgrade).
@parsonsmatt
Copy link
Collaborator

Definitely a bug/oversight if we're supporting (,,) in places but not :&

There's a SqlSelect instance in a new version

@m4dc4p
Copy link
Contributor Author

m4dc4p commented Sep 28, 2021

Much appreciated!

@m4dc4p m4dc4p closed this as completed Sep 28, 2021
@parsonsmatt parsonsmatt reopened this Sep 28, 2021
@parsonsmatt
Copy link
Collaborator

We should still implement ToAlias and ToAliasReference, I think :)

@m4dc4p m4dc4p mentioned this issue Sep 28, 2021
Merged
5 tasks
@m4dc4p
Copy link
Contributor Author

m4dc4p commented Sep 28, 2021

My PR is up but needs approval to run CI on it.

@m4dc4p
Copy link
Contributor Author

m4dc4p commented Sep 30, 2021

Thanks for accepting this one!

@m4dc4p m4dc4p closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m4dc4p @parsonsmatt