Add missing instances to (:&) #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The (:&) operator has an instance for `SqlSelect`, but none for `ToAlias` and `ToAliasReference`. Adding those for parity.
m4dc4p
force-pushed
the
m4dc4p/missing-instances
branch
from
acc864b
to
d6b7614
Compare
parsonsmatt
requested changes
Sep 28, 2021
|
Updates made. |
parsonsmatt
approved these changes
Sep 28, 2021
|
awesome, thank you! |
|
Would you approve the workflow again so CI will run? Apparently this will have to happen each time I push :/ |
parsonsmatt
requested changes
Sep 30, 2021
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
parsonsmatt
approved these changes
Sep 30, 2021
|
going to merge and fix locally, thanks for the contribution! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (:&) operator has an instance for
SqlSelect, but nonefor
ToAliasandToAliasReference. Adding those for parity.I'm not sure if the should be a patch or major version bump. Adding new instances can break existing code, but they are such small instances ... I guessed and bumped the patch number.
I was unable to get the testing environment working locally, so I was going to rely on CI to execute my tests. 🤞
Related to #290.
@sincedeclarations to the Haddock.stylish-haskelland otherwise adhered to the style guide.After submitting your PR: