persistent-2.10 support #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
force-pushed
the
matt/persistent-2.10-support
branch
from
7bf1cd6
to
9431eee
Compare
|
So, we can make this not a breaking change by CPPing in the export depending on the persistent version. #if !MIN_VERSION_persistent(2,10,0)
type Connection = SqlBackend
{-# DEPRECATED Connection "stawp it" #-}
#endifBasically, redefining the type synonyms that were deleted and giving new deprecation warnings. I don't like this idea, fwiw. |
|
@bitemyapp Want to release this now, or would you like to collect some more stuff for the breaking change release? |
|
this gonna be part of 3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately a breaking change due to reexport of
PersistentImport. That should probably be different.