Add test and fix for issue 299 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
approved these changes
Aug 23, 2022
|
As for version - there shouldn't be any changes to the behavior of the library, up to alpha equivalence on SQL queries. And it's a bug fix, not a new feature. I'd probably do a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parsonsmatt This should fix #299 by aggressively re-aliasing. Previously, if an already aliased value was discovered it would not be realiased. This caused an issue where an alias from a lower level could be mixed with an alias from a higher level. This only showed up as an issue when using set operations due to its "smarts" that try to avoid using more Idents than absolutely necessary.
I guess this is a minor version bump?
I would like your eyes on this before I merge.