Google - continually use refresh token #117
Conversation
jehiah
force-pushed
the
always_refresh_117
branch
from
9ce416d
to
f3920fa
Compare
|
@mbland ready for some feedback on this now. I ended up restructuring a bit more than i expected, but i'm much happier with a bunch of the code now, so that makes me 😃 I split apart the horrendously long I'll start some production validation of this change set and update with status of that tomorrow or monday. |
|
Looking now... Though it'll take a little while for me to scour through everything, offhand I really like the new cookie and session abstractions and how they're exposed in the provider interface. Much better than my proposed hack to maintain the status quo. |
| if ok { | ||
| email, user, access_token, err = parseCookieValue(value, p.AesCipher) | ||
| } | ||
| func (p *OauthProxy) LoadCookiedSession(req *http.Request) (*providers.SessionState, time.Duration, error) { |
There was a problem hiding this comment.
Nit: Any reason not to use named return variables as done elsewhere?
|
OK, that seems enough for one round. :-) |
jehiah
force-pushed
the
always_refresh_117
branch
from
0f047d7
to
16ea5e4
Compare
* New SessionState to consolidate email, access token and refresh token * split ServeHttp into individual methods * log on session renewal * log on access token refresh * refactor cookie encription/decription and session state serialization
jehiah
force-pushed
the
always_refresh_117
branch
from
d40bd92
to
d49c3e1
Compare
Google - continually use refresh token
I was mistaken in my understanding in #116 because i thought that when you used a refresh token, the access token you got back was a long term token. It's not and must be continually refreshed when it expires using the refresh token.