[RDY] google: Support restricting access to a specific group(s) #139
Conversation
|
@jburnham Awesome work. I'll review this in the next day or two and get back to you. I'd also love to know if you are successfully using this in production? |
|
haha, not yet, but there are a few places where it would be useful. Just need to set it up. |
|
I still need to support paging as I found an example in https://github.com/google/google-api-go-client/blob/2c0e3555140502254399772c277c54fbaa207e80/examples/gmail.go#L84-L87 |
| "io/ioutil" | ||
| "log" | ||
| "net/http" | ||
| "net/url" | ||
| "strings" | ||
| "time" | ||
|
|
||
| "golang.org/x/oauth2" |
There was a problem hiding this comment.
@jburnham can you capture these dependencies in the Godeps file?
|
@jburnham Thanks!! @markrechler was able to help validate that these changes worked successfully on the Bitly stack so i think we are ready to land this. Can you squash your changes down to a single commit? |
|
@jehiah Great! I'll squash these down later tonight. |
jburnham
force-pushed
the
google_group_auth
branch
from
a23044a
to
3fd8f91
Compare
jburnham
changed the title
|
This is ready now. We also found another clear new use-case for this feature that I'm excited to see in place! |
jburnham
changed the title
[RDY] google: Support restricting access to a specific group(s)
This change should be backwards compatible and only when you pass the three new flags will Google group validation happen.
partially implements features requested in #28 ( getting a list of all groups a user is a member of does not seems to be a single api call and would require listing all groups and then for all groups, querying the group to see if the user is in that group )
potential future improvements (not planned for this PR)